[O2B-1555] Add normalize setter functions to all classes that extend filter model and selection model by NarrowsProjects · Pull Request #2143 · AliceO2Group/Bookkeeping

NarrowsProjects · 2026-04-23T15:09:58Z

I have a JIRA ticket

branch and/or PR name(s) include(s) JIRA ID
issue has "Fix version" assigned
issue "Status" is set to "In review"
PR labels are selected

Notable changes for users:

Setting filters will now display them in the url

Notable changes for developers:

All filters now have a normalized setter that will set the values of the filters based on the output of the normalize getter in query parameter form.

Changes made to the database:

N/A

codecov · 2026-04-23T15:12:06Z

Codecov Report

❌ Patch coverage is 0% with 85 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.89%. Comparing base (2497966) to head (7ec70c2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...blic/components/common/selection/SelectionModel.js	0.00%	15 Missing ⚠️
...onents/Filters/RunsFilter/MagnetsFilteringModel.js	0.00%	12 Missing ⚠️
...s/common/filters/NumericalComparisonFilterModel.js	0.00%	6 Missing ⚠️
.../Filters/common/filters/ProcessedTextInputModel.js	0.00%	5 Missing ⚠️
...ponents/Filters/RunsFilter/EorReasonFilterModel.js	0.00%	4 Missing ⚠️
.../Filters/RunsFilter/MultiCompositionFilterModel.js	0.00%	4 Missing ⚠️
...blic/views/Runs/ActiveColumns/runsActiveColumns.js	0.00%	4 Missing ⚠️
...ponents/Filters/RunsFilter/DetectorsFilterModel.js	0.00%	3 Missing ⚠️
...ic/components/Filters/RunsFilter/GaqFilterModel.js	0.00%	3 Missing ⚠️
...nts/Filters/RunsFilter/RunDefinitionFilterModel.js	0.00%	3 Missing ⚠️
... and 15 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2143      +/-   ##
==========================================
- Coverage   45.93%   45.89%   -0.05%     
==========================================
  Files        1036     1035       -1     
  Lines       17150    17167      +17     
  Branches     3115     3124       +9     
==========================================
  Hits         7878     7878              
- Misses       9272     9289      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…h SelectionModel

…ownModel as submodels to extend it instead

isaachilly · 2026-05-12T09:57:29Z

+     *
+     * @return {string}
+     */
+    set normalized(value) {


What happens if value is null or undefined? Could value ever be null or undefined? Maybe not in UI but maybe if passed in URL? What do you think? Goes for all the setters.

Since queryRouter omits any values that are undefined when computing its params field, the normalized values derived from params will always be usable.

As a result, if a value is passed via URL (which is why the setters exist), neither value nor its equivalent can end up being undefined.

To clarify, while undefined can't really reach the setters, empty strings can

…tions received in the normalized setter

…l and NumericalComparisonModel

graduta

Nice effort, seems to be in the right direction. I wanted to ask if you had the opportunity to look at tests or update them? More specifically, given the refactor, what was your testing strategy to ensure consistency across changes?

graduta · 2026-05-26T09:01:45Z

+     * Accounts for the options being either RemoteData or an array.
     *
-     * @return {SelectionDropdownModel} the dropdown model
+     * @param {object}


Incomplete docs

…etter

NarrowsProjects · 2026-05-26T10:57:29Z

Nice effort, seems to be in the right direction. I wanted to ask if you had the opportunity to look at tests or update them? More specifically, given the refactor, what was your testing strategy to ensure consistency across changes?

The refactors were all in models that already had tests that checked the effectiveness.
The only thing of note that changed was how the runTypes filter had the return type of it's normalized function changed.

However, according to the the back-end code. And the test that checks the effectiveness of the runTypes filter on the front-end, this change did not make a difference.

So, I'm not quite sure which tests would be updated.

…s-to-all-classes-that-extend-FilterModel-and-SelectionModel

NarrowsProjects self-assigned this Apr 23, 2026

NarrowsProjects requested a review from graduta as a code owner April 23, 2026 15:09

NarrowsProjects added frontend javascript Pull requests that update Javascript code labels Apr 23, 2026

NarrowsProjects changed the base branch from main to feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url April 23, 2026 15:10

NarrowsProjects changed the title ~~Impov/o2 b 1555/add normalize setter functions to all classes that extend filter model and selection model~~ [O2B-1555] Add normalize setter functions to all classes that extend filter model and selection model Apr 23, 2026

NarrowsProjects force-pushed the impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel branch 11 times, most recently from e540f27 to edb626f Compare April 27, 2026 07:04

NarrowsProjects force-pushed the feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url branch from 4a30d27 to ae6c287 Compare April 27, 2026 07:17

NarrowsProjects force-pushed the impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel branch 2 times, most recently from 88cc4f4 to 49ed030 Compare April 27, 2026 07:36

Base automatically changed from feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url to main May 5, 2026 10:02

NarrowsProjects force-pushed the impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel branch 4 times, most recently from bc70145 to beca3c1 Compare May 7, 2026 17:51

NarrowsProjects added 4 commits May 11, 2026 08:49

feat: add normalize setter to SelectionModel and FilteringModel

7db974b

chore: add mundain normalized setters

b5d8fc4

chore: remove all mentions of selectionFilterModel and replace it wit…

b42a43c

…h SelectionModel

make MagnetsfilteringModel extend RemoteDataSelectionDropdown

116fdef

feat: change all filters that have only ObservableBasedSelectionDropd…

319bb4d

…ownModel as submodels to extend it instead

NarrowsProjects force-pushed the impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel branch from beca3c1 to 319bb4d Compare May 11, 2026 06:50

isaachilly reviewed May 12, 2026

View reviewed changes

Comment thread lib/public/components/common/selection/SelectionModel.js Outdated

isaachilly reviewed May 12, 2026

View reviewed changes

Comment thread lib/public/components/common/selection/SelectionModel.js

isaachilly reviewed May 12, 2026

View reviewed changes

Comment thread lib/public/components/Filters/RunsFilter/MagnetsFilteringModel.js Outdated

isaachilly reviewed May 12, 2026

View reviewed changes

Comment thread lib/public/components/Filters/RunsFilter/MagnetsFilteringModel.js

NarrowsProjects commented May 12, 2026

View reviewed changes

Comment thread lib/public/components/common/selection/SelectionModel.js Outdated

NarrowsProjects added 3 commits May 12, 2026 14:55

chore: remove the backlog clear from setAvailable options and trim op…

911cd2e

…tions received in the normalized setter

chore: fix comment on magnetsFilteringModel

f9dc13a

feat: guard against parsing empty strings to NaN in DateTimeInputMode…

1443e47

…l and NumericalComparisonModel

NarrowsProjects force-pushed the impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel branch from f314b72 to 1443e47 Compare May 19, 2026 09:34

NarrowsProjects requested a review from isaachilly May 19, 2026 11:53

graduta reviewed May 26, 2026

View reviewed changes

NarrowsProjects added 4 commits May 26, 2026 11:53

chore: add missing documentation for magnetsFilteringModel

79397e1

feat: guard against undefined selection in magnetsFilteringModel

2d0c916

chore: can normalized getters in tagFilterModel

1d9af1e

chore: remove extra space for negation in SelectionModel normalized s…

1ec7cb6

…etter

NarrowsProjects requested a review from graduta May 26, 2026 11:02

chore: fix eslint issues

4b9b459

graduta approved these changes May 26, 2026

View reviewed changes

Merge branch 'main' into impov/O2B-1555/Add-normalize-setter-function…

7ec70c2

…s-to-all-classes-that-extend-FilterModel-and-SelectionModel

graduta merged commit 469ef0f into main May 26, 2026
39 of 42 checks passed

graduta deleted the impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel branch May 26, 2026 14:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[O2B-1555] Add normalize setter functions to all classes that extend filter model and selection model#2143

[O2B-1555] Add normalize setter functions to all classes that extend filter model and selection model#2143
graduta merged 14 commits into
mainfrom
impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel

NarrowsProjects commented Apr 23, 2026 •

edited by graduta

Loading

Uh oh!

codecov Bot commented Apr 23, 2026 •

edited

Loading

Uh oh!

Uh oh!

isaachilly May 12, 2026 •

edited

Loading

Uh oh!

NarrowsProjects May 12, 2026 •

edited

Loading

Uh oh!

NarrowsProjects May 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graduta left a comment

Uh oh!

graduta May 26, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NarrowsProjects commented May 26, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

NarrowsProjects commented Apr 23, 2026 • edited by graduta Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I have a JIRA ticket

Uh oh!

codecov Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

isaachilly May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NarrowsProjects May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NarrowsProjects May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graduta left a comment

Choose a reason for hiding this comment

Uh oh!

graduta May 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NarrowsProjects commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

NarrowsProjects commented Apr 23, 2026 •

edited by graduta

Loading

codecov Bot commented Apr 23, 2026 •

edited

Loading

isaachilly May 12, 2026 •

edited

Loading

NarrowsProjects May 12, 2026 •

edited

Loading

NarrowsProjects May 19, 2026 •

edited

Loading

NarrowsProjects commented May 26, 2026 •

edited

Loading