Skip to content

[Client] Add alert if idle time to resume computing is greater than idle time to suspend computing #5270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidpanderson merged 4 commits into from
Jun 15, 2023
Merged

[Client] Add alert if idle time to resume computing is greater than idle time to suspend computing #5270

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d1331dd
feat: check for condition where idle time to resume computing is grea…
Vulpine05 Jun 13, 2023
81ac34d
fix: revise conditional statement and message
Vulpine05 Jun 14, 2023
5588cf2
Revised to print to hundredths
Vulpine05 Jun 15, 2023
aab5bae
Fixed missing period to round to hundredths
Vulpine05 Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions client/cs_prefs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// This file is part of BOINC.
// http://boinc.berkeley.edu
// Copyright (C) 2008 University of California
// Copyright (C) 2023 University of California
//
// BOINC is free software; you can redistribute it and/or modify it
// under the terms of the GNU Lesser General Public License
Expand Down Expand Up @@ -675,7 +675,7 @@ void CLIENT_STATE::print_global_prefs() {
//
msg_printf(NULL, MSG_INFO, "- When computer is in use");
msg_printf(NULL, MSG_INFO,
"- 'In use' means mouse/keyboard input in last %.1f minutes",
"- 'In use' means mouse/keyboard input in last %.2f minutes",
global_prefs.idle_time_to_run
);
if (!global_prefs.run_if_user_active) {
Expand Down Expand Up @@ -736,10 +736,20 @@ void CLIENT_STATE::print_global_prefs() {
);
if (global_prefs.suspend_if_no_recent_input > 0) {
msg_printf(NULL, MSG_INFO,
"- Suspend if no input in last %f minutes",
"- Suspend if no input in last %.2f minutes",
global_prefs.suspend_if_no_recent_input
);
}
// It is possible that computing (CPU or GPU) could be suspended indefinitely if the idle time required before continuing computing
// is longer than the time required to suspend computing when the computer is idle. In this case an alert message will be sent.
//
if ((!global_prefs.run_if_user_active || !global_prefs.run_gpu_if_user_active) && (global_prefs.suspend_if_no_recent_input > 0) &&
((global_prefs.idle_time_to_run - global_prefs.suspend_if_no_recent_input) >= 0)) {
msg_printf(0, MSG_USER_ALERT,
"Preference settings don't allow computing (%.2f > %.2f). Please review.",
global_prefs.idle_time_to_run, global_prefs.suspend_if_no_recent_input
);
}

// general
//
Expand Down