Conversation
… reference author
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Member
|
I'm sorry to say that I don't agree with this change. I definitely see the point of having LFP in the name instead of Xu 2015, but I think that Xu 2015 is just one instance of a LP2770120 LFP/graphite cell. It's the same with Chen -- it's just one parameter set of the M50. |
Collaborator
Author
|
@augustjohansson
|
Member
|
No, I don't think so. We only have 3 parameter sets so it's not that difficult to keep track of them? Also in pybamm I'm pretty sure that you refer to the data set by the author-year-system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.