fix(api): handle null kill counts with COALESCE in ranking query (#84) #24
ci.yml
on: pull_request
API (typecheck, test, build)
1m 29s
Server (typecheck, lint, build)
22s
Frontend (typecheck, lint, build)
51s
Docker build checks
1m 25s
Annotations
3 errors and 10 warnings
|
API (typecheck, test, build)
Process completed with exit code 1.
|
|
src/tests/platform.integration.test.ts > public endpoints health runtime-config ranking and wiki respond:
api/src/tests/platform.integration.test.ts#L27
AssertionError: Expected values to be strictly equal:
500 !== 200
- Expected
+ Received
- 200
+ 500
❯ src/tests/platform.integration.test.ts:27:12
|
|
src/tests/market.integration.test.ts > market limpieza masiva cancela items vendidos por NPCs y reintegra comisión:
api/src/lib/gameData.ts#L259
Error: ENOENT: no such file or directory, open '/home/runner/work/OpenAO/OpenAO/api/src/jsons/npcs.json'
❯ loadNpcsJsonFromFile src/lib/gameData.ts:259:31
❯ loadSeedNpcsJson src/lib/gameData.ts:253:12
❯ ensureSeededInternal src/repositories/gameNpcs.ts:223:22
❯ ensureSeeded src/repositories/gameNpcs.ts:265:5
❯ listNpcSoldItemIds src/repositories/gameNpcs.ts:51:5
❯ getNpcSoldItemId src/tests/market.integration.test.ts:19:21
❯ src/tests/market.integration.test.ts:311:29
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { errno: -2, code: 'ENOENT', syscall: 'open', path: '/home/runner/work/OpenAO/OpenAO/api/src/jsons/npcs.json' }
|
|
Server (typecheck, lint, build)
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4, actions/setup-node@v4, pnpm/action-setup@v4. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Frontend (typecheck, lint, build)
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4, actions/setup-node@v4, pnpm/action-setup@v4. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Frontend (typecheck, lint, build):
frontend/components/BuffStatusSidebar.tsx#L372
Using `<img>` could result in slower LCP and higher bandwidth. Consider using `<Image />` from `next/image` or a custom image loader to automatically optimize images. This may incur additional usage or cost from your provider. See: https://nextjs.org/docs/messages/no-img-element
|
|
Frontend (typecheck, lint, build):
frontend/components/BuffStatusSidebar.tsx#L226
React Hook React.useEffect has a missing dependency: 'hud'. Either include it or remove the dependency array
|
|
Docker build checks
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4, docker/build-push-action@v6, docker/setup-buildx-action@v3. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Sensitive data should not be used in the ARG or ENV commands:
frontend/Dockerfile#L30
SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "DO_SPACES_ACCESS_KEY_ID")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/
|
|
Sensitive data should not be used in the ARG or ENV commands:
frontend/Dockerfile#L41
SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "GAME_DATA_ADMIN_PROXY_TOKEN")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/
|
|
Sensitive data should not be used in the ARG or ENV commands:
frontend/Dockerfile#L32
SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "GAME_DATA_ADMIN_PROXY_TOKEN")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/
|
|
Sensitive data should not be used in the ARG or ENV commands:
frontend/Dockerfile#L31
SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "DO_SPACES_SECRET_ACCESS_KEY")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/
|
|
API (typecheck, test, build)
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4, actions/setup-node@v4, pnpm/action-setup@v4. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
Bitcoindefi~OpenAO~BR75C0.dockerbuild
|
34.8 KB |
sha256:aa94725f1df675ed5a59cf8a29db90e5d48d14931c8323a21aa19921b3eb9689
|
|
|
Bitcoindefi~OpenAO~ELBDHX.dockerbuild
|
25.3 KB |
sha256:b0df30cc12c8717ee2d155e3b95e83bacb3824f516f5666f69d63ab14dfe15a2
|
|
|
Bitcoindefi~OpenAO~H4ZYNQ.dockerbuild
|
33 KB |
sha256:b98387a2e3434dd704a334c65d40920d97f9bc9a88f27d68877ed232b660ec7f
|
|