Conversation
SimonSadler
reviewed
Jun 30, 2026
SimonSadler
left a comment
SimonSadler
left a comment
There was a problem hiding this comment.
I think we should install pre-commit as part of the dev tools.
Collaborator
Author
|
I have moved it to the |
|
I just ran some tests using the pre-commit hooks and it all worked but there was some back and forth as faults were found. How do you feel about adding the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds pre-commit hooks for the ruff, mypy, and blackdoc checks that are used in CI.
It adds pre-commit to the developer dependencies and adds instructions for installing the hooks when doing a development install.
It also updates the black and blackdoc versions to newer versions that resolve the previous incompatibility issue.