From d8030d21136aacd438c524ab272b148f503ef360 Mon Sep 17 00:00:00 2001 From: moul <94029+moul@users.noreply.github.com> Date: Wed, 10 Jun 2026 22:19:46 +0200 Subject: [PATCH] fix: ignore stale bank selection responses --- src/live_mem/static/js/bank.js | 6 ++++- tests/test_live_ui_bank_race_guard.py | 33 +++++++++++++++++++++++++++ 2 files changed, 38 insertions(+), 1 deletion(-) create mode 100644 tests/test_live_ui_bank_race_guard.py diff --git a/src/live_mem/static/js/bank.js b/src/live_mem/static/js/bank.js index 97c4a05..472efcf 100644 --- a/src/live_mem/static/js/bank.js +++ b/src/live_mem/static/js/bank.js @@ -42,6 +42,8 @@ function renderBankTabs() { async function selectBank(filename) { app.currentBankFile = filename; + const requestedSpaceId = app.spaceId; + const requestedFilename = filename; // Mettre à jour les onglets actifs document.querySelectorAll('.bank-tab').forEach(t => { @@ -52,7 +54,8 @@ async function selectBank(filename) { el.innerHTML = '
Loading…
'; try { - const r = await apiLoadBankFile(app.spaceId, filename); + const r = await apiLoadBankFile(requestedSpaceId, requestedFilename); + if (app.spaceId !== requestedSpaceId || app.currentBankFile !== requestedFilename) return; if (r.status === 'ok' && r.content) { el.innerHTML = `
${md(r.content)}
`; } else { @@ -60,6 +63,7 @@ async function selectBank(filename) { } } catch (e) { if (e.message !== 'Unauthorized') { + if (app.spaceId !== requestedSpaceId || app.currentBankFile !== requestedFilename) return; el.innerHTML = `
❌ ${esc(e.message)}
`; } } diff --git a/tests/test_live_ui_bank_race_guard.py b/tests/test_live_ui_bank_race_guard.py new file mode 100644 index 0000000..168274a --- /dev/null +++ b/tests/test_live_ui_bank_race_guard.py @@ -0,0 +1,33 @@ +from pathlib import Path +import re + + +ROOT = Path(__file__).resolve().parents[1] +BANK_JS = ROOT / "src" / "live_mem" / "static" / "js" / "bank.js" + + +def _select_bank_body() -> str: + source = BANK_JS.read_text() + match = re.search(r"async function selectBank\(filename\) \{(?P.*?)\n\}", source, re.S) + assert match, "selectBank(filename) not found in bank.js" + return match.group("body") + + +def test_select_bank_uses_captured_space_and_filename_for_load(): + body = _select_bank_body() + + assert "const requestedSpaceId = app.spaceId;" in body + assert "const requestedFilename = filename;" in body + assert "apiLoadBankFile(requestedSpaceId, requestedFilename)" in body + + +def test_select_bank_drops_stale_responses_before_rendering(): + body = _select_bank_body() + stale_guard = ( + "app.spaceId !== requestedSpaceId " + "|| app.currentBankFile !== requestedFilename" + ) + + assert stale_guard in body + assert body.index(stale_guard) < body.index('el.innerHTML = `
') + assert body.rindex(stale_guard) < body.rindex('el.innerHTML = `
❌')