From 665da2f1c0867d8c6c57584ef679000fa224c9d2 Mon Sep 17 00:00:00 2001 From: "Vit Horacek (via MelvinBot)" Date: Fri, 10 Apr 2026 04:56:19 +0000 Subject: [PATCH] Fix flaky PersonalDetailsOnboarding tests by awaiting batched updates after button press Add waitForBatchedUpdatesWithAct() after fireEvent.press to flush pending Onyx state updates and React effects before asserting navigation calls. This follows the established pattern used across 57+ UI test files. Co-authored-by: Vit Horacek --- tests/ui/PersonalDetailsOnboarding.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/ui/PersonalDetailsOnboarding.tsx b/tests/ui/PersonalDetailsOnboarding.tsx index 66565567b6991..d165bcc96aaa1 100644 --- a/tests/ui/PersonalDetailsOnboarding.tsx +++ b/tests/ui/PersonalDetailsOnboarding.tsx @@ -102,6 +102,7 @@ describe('OnboardingPersonalDetails Page', () => { // Submit the form fireEvent.press(screen.getByText(TestHelper.translateLocal('common.continue'))); + await waitForBatchedUpdatesWithAct(); await waitFor(() => { expect(navigate).toHaveBeenCalledWith(ROUTES.ONBOARDING_PRIVATE_DOMAIN.getRoute()); @@ -133,6 +134,7 @@ describe('OnboardingPersonalDetails Page', () => { // Submit the form fireEvent.press(screen.getByText(TestHelper.translateLocal('common.continue'))); + await waitForBatchedUpdatesWithAct(); await waitFor(() => { expect(navigate).toHaveBeenCalledWith(ROUTES.ONBOARDING_PRIVATE_DOMAIN.getRoute());