Dynamic Trees do not generate TFC wood/twig and fallen leaves in autumn

[qq4040]

Dynamic Trees do not generate TFC wood/twig and fallen leaves in autumn

Description:
Dynamic Trees in TFC do not generate tfc:wood/twig and tfc:wood/fallen_leaves during autumn. This causes missing resources like leaves needed for composting and reduces the visual immersion compared to standard TFC trees.

Steps to Reproduce:

1. Plant two trees next to each other: one standard Kapok and one Dynamic Kapok.

2. Increase tick speed for faster generation:

   /gamerule randomTickSpeed 1000
   

3. Advance time to autumn using multiple /time set day commands.

4. Observe that standard TFC trees generate twigs and fallen leaves, but Dynamic Trees do not.

Expected Behavior:
Dynamic Trees should generate tfc:wood/twig and tfc:wood/fallen_leaves like normal TFC trees, so resources like leaves are available for composting and the seasonal aesthetic is preserved.

Screenshot / Evidence:

Environment:

• Minecraft 1.20.1

• Mods (latest versions as of now):

  • TerraFirmaCraft (TFC)
  • Dynamic Trees (DT)
  • Dynamic Trees TFC (DTTFC)

[IttoSanzzo]

Yup, it would be really good, and seems like it's not even that annoying to implement...

[copygirl]

I was looking into this. Does this require registering a custom leaves block that extends DynamicLeavesBlock and overrides the randomTick function? I unfortunately had no idea how to tell DT to use the custom leaves block.

Also, I've noticed in the code that TFC leaves have a chance to drop tree clutter when naturally despawning. Would it make sense for dynamic tree leaves to call this code as well when removeIfInvalid returns true? Maybe not, since trees grow over time and leaves often rearrange so it would spawn clutter all year round?

Here's how far I got:

package org.labellum.mc.dttfc.content;

import com.dtteam.dynamictrees.block.leaves.DynamicLeavesBlock;
import com.dtteam.dynamictrees.block.leaves.LeavesProperties;
import com.dtteam.dynamictrees.config.DTConfigs;
import net.dries007.tfc.client.overworld.SolarCalculator;
import net.dries007.tfc.common.blocks.wood.TFCLeavesBlock;
import net.dries007.tfc.util.calendar.Calendars;
import net.dries007.tfc.util.calendar.Season;
import net.minecraft.core.BlockPos;
import net.minecraft.server.level.ServerLevel;
import net.minecraft.util.RandomSource;
import net.minecraft.world.level.block.state.BlockState;

public class TFCDynamicLeavesBlock extends DynamicLeavesBlock {

    public TFCLeavesBlock tfcLeaves;

    public TFCDynamicLeavesBlock(
        final TFCLeavesBlock tfcLeaves,
        final LeavesProperties leavesProperties,
        final Properties properties
    ) {
        super(leavesProperties, properties);
        this.tfcLeaves = tfcLeaves;
    }

    @Override
    public void randomTick(BlockState state, ServerLevel level, BlockPos pos, RandomSource rand) {
        // During fall (the season), randomly create some clutter.
        if (!state.getValue(PERSISTENT) && (rand.nextFloat() < 0.0005f)) {
            boolean isNorthernHemisphere = SolarCalculator.getInNorthernHemisphere(pos, level);
            Season season = Calendars.SERVER.getHemispheralCalendarMonthOfYear(isNorthernHemisphere).getSeason();
            if (season == Season.FALL) tfcLeaves.createDestructionEffects(state, level, pos, rand, true);
        }
        // Default impl called after because it might despawn the leaves block.
        super.randomTick(state, level, pos, rand);
    }

}