increase minimum class region size to avoid OOB access under minimum class region size config#331
Merged
Conversation
Member
|
It should be set to a higher value than the initial region table sized to some logical amount. |
rdevshp
force-pushed
the
regions_size_oob_fix
branch
from
8c00080 to
9ce3f61
Compare
Contributor
Author
|
I've updated the static_assert to require CONFIG_CLASS_REGION_SIZE >= 25165824 |
Member
|
The minimum should probably be a power of 2. It's best if most of these are powers of 2 for higher performance, although it's too much trouble to check for it. |
…class region size config
rdevshp
force-pushed
the
regions_size_oob_fix
branch
from
9ce3f61 to
8b18cf0
Compare
Contributor
Author
|
I have switched it to require CONFIG_CLASS_REGION_SIZE >= 33554432, which is a power of 2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under the current configuration limits, when CONFIG_CLASS_REGION_SIZE == 1048576, MAX_REGION_TABLE_SIZE can be smaller than INITIAL_REGION_TABLE_SIZE, which can cause OOB access. This PR proposes a fix for this issue.