-
Notifications
You must be signed in to change notification settings - Fork 25
Popover final #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
krshubham
wants to merge
18
commits into
Grasia:master
Choose a base branch
from
krshubham:popover-final
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Popover final #383
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
06fd84c
Merge pull request #1 from Grasia/master
22bec23
gulpfile error handlers for pipes added
21a3017
Merge branch 'master' of https://github.com/krshubham/teem
87894a9
Added basic popover
aa7fcce
Merge remote-tracking branch 'upstream/master'
9dd4e63
Some changes in the popover
a5e7980
Added some stable changes to popover
46b44a9
separating bug fixes
83da6ea
Popover added + gulpfile fix
16881d7
Removed jshint warnings
997258f
Added automatic pull of teemlp docker image
092dc6f
Merge branch 'master' into popover-final
dada231
some final corrections added
7b91689
Corrected issues related for pull#380
cf09fb8
Added max-width and max-height for popover image
4701fbe
Moved css to pad.sass
922e961
Fixed color in pad sass
e33c15c
gulpfile restored to grasia/teem:master
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not to use one of our colors as $light-grey?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its a bit more darker than what I wanted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The colors have been carefully chosen by our designer @elenamv to combine together. Please see if there is a lighter color in our selection that you can use, maybe $pale-blue?