Skip to content

Commit 171c665

Browse files
docs(kotlin-sdk): cite the Swift source in the signMessage KDoc
Kotlin-sdk porting guideline: when porting behavior from iOS, cite the Swift source file in the KDoc, as the neighbouring methods do (sendToAddresses -> SendViewModel.swift, tokens -> TokenActions.swift). Names ManagedCoreWallet.signMessage(address:message:) and explains the one signature divergence (Swift builds a per-call MnemonicResolver, so it takes no signer parameter). Review follow-up from the original PR (dashpay#4259). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent 92f9452 commit 171c665

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

packages/kotlin-sdk/sdk/src/main/kotlin/org/dashfoundation/dashsdk/wallet/ManagedPlatformWallet.kt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,11 @@ class ManagedPlatformWallet internal constructor(
178178
* signature as base64 — a **classic Dash signed message**, byte-for-byte
179179
* compatible with dashj's `ECKey.signMessage` and Dash Core's `signmessage`
180180
* RPC, and verifiable by `verifymessage`, `ECKey.verifyMessage`, and
181-
* CrowdNode's server-side check.
181+
* CrowdNode's server-side check. Android port of Swift's
182+
* `ManagedCoreWallet.signMessage(address:message:)`
183+
* (`ManagedCoreWallet.swift`), which takes no signer parameter because it
184+
* builds a per-call `MnemonicResolver` internally; here the manager's
185+
* resolver handle is passed explicitly, as on the send paths.
182186
*
183187
* **The format.** The signed digest is
184188
* `SHA256d(prefix ‖ varint(bytes.size) ‖ bytes)` over

0 commit comments

Comments
 (0)