-
-
Notifications
You must be signed in to change notification settings - Fork 382
review: test: add regression test for toString() with complex comments #6727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MartinWitt
wants to merge
3
commits into
master
Choose a base branch
from
fix/tostringbugtest
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+55
−59
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
40 changes: 40 additions & 0 deletions
40
src/test/java/spoon/test/prettyprinter/ToStringCommentTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| /** | ||
| * Copyright (C) 2006-2018 INRIA and contributors | ||
| * Spoon - http://spoon.gforge.inria.fr/ | ||
| * | ||
| * This software is governed by the CeCILL-C License under French law and | ||
| * abiding by the rules of distribution of free software. You can use, modify | ||
| * and/or redistribute the software under the terms of the CeCILL-C license as | ||
| * circulated by CEA, CNRS and INRIA at http://www.cecill.info. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| * FITNESS FOR A PARTICULAR PURPOSE. See the CeCILL-C License for more details. | ||
| * | ||
| * The fact that you are presently reading this means that you have had | ||
| * knowledge of the CeCILL-C license and you accept the terms. | ||
| */ | ||
| package spoon.test.prettyprinter; | ||
|
|
||
| import spoon.Launcher; | ||
| import spoon.reflect.declaration.CtType; | ||
| import spoon.testing.utils.ModelTest; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.junit.jupiter.api.Assertions.assertNotNull; | ||
| import static org.junit.jupiter.api.Assertions.assertFalse; | ||
|
|
||
| public class ToStringCommentTest { | ||
|
|
||
| @ModelTest("./src/test/resources/spoon/test/prettyprinter/toStringCommentTest") | ||
| public void testToStringWithComplexComments(Launcher launcher) { | ||
| // contract: toString() should not crash when processing complex comments | ||
| // This is a regression test for issue #3382 where cleanComment method could crash | ||
| var types = launcher.getFactory().Class().getAll(); | ||
| assertThat(types).withFailMessage("Should load test resources").isNotEmpty(); | ||
|
|
||
| for (CtType<?> type : types) { | ||
| assertThat(type.toString()).withFailMessage("toString() should not return null for type: " + type.getQualifiedName()).isNotNull(); | ||
| } | ||
| } | ||
| } | ||
This file was deleted.
Oops, something went wrong.
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.