Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 118 additions & 0 deletions .github/workflows/run-cli-smoke-tests.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,118 @@
name: CLI Distro Smoke Tests

on:
pull_request:
types: [opened, synchronize]
paths:
- "**.go"
- "go.mod"
- "go.sum"
- ".goreleaser.yaml"
- "smoke-tests/**"
- ".github/workflows/run-cli-smoke-tests.yml"

workflow_dispatch:
workflow_call:

jobs:
build:
name: Build CLI + packages
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1

- name: Set up Go
uses: actions/setup-go@40f1582b2485089dde7abd97c1529aa768e1baff # v5.6.0
with:
go-version: "1.25.9"

- name: Build static binary
run: |
CGO_ENABLED=0 go build -trimpath \
-ldflags "-X github.com/Infisical/infisical-merge/packages/util.CLI_VERSION=0.0.0-smoke" \
-o infisical .

- name: Install nfpm
run: |
go install github.com/goreleaser/nfpm/v2/cmd/nfpm@latest

Check warning on line 37 in .github/workflows/run-cli-smoke-tests.yml

View check run for this annotation

Claude / Claude Code Review

Pin nfpm install to a specific version

Line 37 installs nfpm with `@latest`, which is inconsistent with the rest of this workflow (every `uses:` is SHA-pinned with a version comment) and with other workflows that pin tool versions (e.g. `build-rdp-bridge.yml` uses `cargo install cross --locked --version 0.2.5`). Pin to a tagged release such as `go install github.com/goreleaser/nfpm/v2/cmd/nfpm@v2.40.0` so the smoke-test artifacts are reproducible and a future upstream nfpm change cannot silently alter package layout for unrelated PRs
Comment thread
x032205 marked this conversation as resolved.
Outdated

- name: Create packages
run: |
mkdir -p smoke-tests/dist
nfpm package --config smoke-tests/nfpm.yaml --packager deb --target smoke-tests/dist/infisical.deb
nfpm package --config smoke-tests/nfpm.yaml --packager rpm --target smoke-tests/dist/infisical.rpm
nfpm package --config smoke-tests/nfpm.yaml --packager apk --target smoke-tests/dist/infisical.apk
nfpm package --config smoke-tests/nfpm.yaml --packager archlinux --target smoke-tests/dist/infisical.pkg.tar.zst

- name: Upload packages
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
with:
name: smoke-test-packages
path: |
smoke-tests/dist/
smoke-tests/smoke.sh
retention-days: 1

smoke-test:
name: ${{ matrix.distro }}
needs: build
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
include:
- distro: ubuntu-22.04
image: ubuntu:22.04
pkg: infisical.deb
install: "dpkg -i"

- distro: ubuntu-24.04
image: ubuntu:24.04
pkg: infisical.deb
install: "dpkg -i"

- distro: debian-12
image: debian:12
pkg: infisical.deb
install: "dpkg -i"

- distro: fedora-40
image: fedora:40
pkg: infisical.rpm
install: "rpm -i"

- distro: rockylinux-9
image: rockylinux:9
pkg: infisical.rpm
install: "rpm -i"

- distro: amazonlinux-2023
image: amazonlinux:2023
pkg: infisical.rpm
install: "rpm -i"

- distro: alpine-3.20
image: alpine:3.20
pkg: infisical.apk
install: "apk add --allow-untrusted"

- distro: archlinux
image: archlinux:latest
pkg: infisical.pkg.tar.zst
install: "pacman -U --noconfirm"

steps:
- name: Download packages
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
with:
name: smoke-test-packages
path: artifacts

- name: Run smoke tests on ${{ matrix.distro }}
run: |
chmod +x artifacts/smoke-tests/smoke.sh
docker run --rm \
-v "${{ github.workspace }}/artifacts/smoke-tests/dist:/dist" \
-v "${{ github.workspace }}/artifacts/smoke-tests/smoke.sh:/smoke.sh" \
${{ matrix.image }} \
sh -c "${{ matrix.install }} /dist/${{ matrix.pkg }} && /smoke.sh"

Check failure on line 118 in .github/workflows/run-cli-smoke-tests.yml

View check run for this annotation

Claude / Claude Code Review

Smoke-test jobs reference nonexistent artifact paths

All matrix jobs will fail at the `chmod` step: `actions/upload-artifact@v4` strips the least common ancestor of the supplied paths, so the artifact contains `dist/...` and `smoke.sh` at the root (not under a `smoke-tests/` prefix). After download to `artifacts/`, the files live at `artifacts/dist/` and `artifacts/smoke.sh`, but the next step references `artifacts/smoke-tests/...`. Fix by referencing the correct paths, e.g. `chmod +x artifacts/smoke.sh` and bind-mount `artifacts/dist` and `artifa
Comment thread
x032205 marked this conversation as resolved.
12 changes: 12 additions & 0 deletions smoke-tests/nfpm.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
name: infisical
arch: amd64
platform: linux
version: v0.0.0-smoke
maintainer: "Infisical, Inc"
description: "The official Infisical CLI"
homepage: "https://infisical.com/"
license: MIT

contents:
- src: ./infisical
dst: /usr/bin/infisical
72 changes: 72 additions & 0 deletions smoke-tests/smoke.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
#!/bin/sh
set -e

DISTRO="unknown"
if [ -f /etc/os-release ]; then
DISTRO=$(. /etc/os-release && echo "$PRETTY_NAME")
fi

echo "=== CLI Smoke Tests ==="
echo "Distro: $DISTRO"
echo "Arch: $(uname -m)"
echo ""

passed=0
failed=0

pass() {
passed=$((passed + 1))
echo "PASS: $1"
}

fail() {
failed=$((failed + 1))
echo "FAIL: $1"
}

if ! command -v infisical >/dev/null 2>&1; then
fail "infisical binary not found in PATH"
exit 1
fi
pass "binary found at $(command -v infisical)"

# --version
if output=$(infisical --version 2>&1); then
pass "--version ($output)"
else
fail "--version exited with $?"
fi

# --help
if infisical --help >/dev/null 2>&1; then
pass "--help"
else
fail "--help"
fi

# core subcommands
for cmd in secrets run export login agent gateway; do
if infisical "$cmd" --help >/dev/null 2>&1; then
pass "$cmd --help"
else
fail "$cmd --help"
fi
done

# shared library check
BINARY_PATH=$(command -v infisical)
if command -v ldd >/dev/null 2>&1; then
if ldd "$BINARY_PATH" 2>&1 | grep -qi "not found"; then
fail "missing shared libraries"
ldd "$BINARY_PATH" 2>&1
else
pass "no missing shared libraries"
fi

Check warning on line 64 in smoke-tests/smoke.sh

View check run for this annotation

Claude / Claude Code Review

Shared-library check is a no-op for the static binary it tests

The shared-library check at smoke-tests/smoke.sh:55-63 is a no-op for the static binary it tests: with `CGO_ENABLED=0` (run-cli-smoke-tests.yml:31-34) the binary has no dynamic deps, so glibc `ldd` prints `not a dynamic executable` and musl/Alpine prints similar — neither output ever contains the substring `not found`, so `PASS: no missing shared libraries` is printed regardless of binary content. Either drop the check or special-case the `not a dynamic executable` output with a clearer "skipped
Comment thread
x032205 marked this conversation as resolved.
fi

echo ""
echo "Results: $passed passed, $failed failed"

if [ "$failed" -gt 0 ]; then
exit 1
fi
Loading