From f1481d03f5dad7aef2155508d5f6dfd1cf72acc5 Mon Sep 17 00:00:00 2001
From: Danielle Lindblom <danielle.lindblom@gmail.com>
Date: Wed, 8 Jan 2025 10:35:09 -0700
Subject: [PATCH 1/4] fix: make close button for navigation menu accessible to
 screen readers

---
 components/NavDrawer/NavDrawer.tsx | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/components/NavDrawer/NavDrawer.tsx b/components/NavDrawer/NavDrawer.tsx
index f3f7edc0..6497026d 100644
--- a/components/NavDrawer/NavDrawer.tsx
+++ b/components/NavDrawer/NavDrawer.tsx
@@ -128,8 +128,10 @@ const DrawerTitle = React.forwardRef<
       {...props}
     />
 
-    <DrawerClose>
-      <X />
+    <DrawerClose aria-label='close navigation menu'>
+      <X 
+      aria-hidden='true'
+      />
     </DrawerClose>
   </div>
 ));

From 60ad3cb3e517ca34809cd8c390884111be4a0c1e Mon Sep 17 00:00:00 2001
From: Danielle Lindblom <danielle.lindblom@gmail.com>
Date: Wed, 8 Jan 2025 10:40:01 -0700
Subject: [PATCH 2/4] fix: a11y - add properties to make hamburger menu icon
 screenreader accessible

---
 components/Nav/Nav.tsx | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/components/Nav/Nav.tsx b/components/Nav/Nav.tsx
index 415cfe65..8798ad58 100644
--- a/components/Nav/Nav.tsx
+++ b/components/Nav/Nav.tsx
@@ -61,8 +61,15 @@ export const Nav = (): JSX.Element => {
       <ul>
         <li>
           <Drawer open={open} onOpenChange={setOpen}>
-            <DrawerTrigger data-testid="drawer-trigger">
-              <Menu className="text-foreground" />
+            <DrawerTrigger 
+            data-testid="drawer-trigger"
+            aria-haspopup='menu'
+            aria-label='open navigation menu'
+            >
+              <Menu 
+              className="text-foreground" 
+              aria-hidden='true'
+              />
             </DrawerTrigger>
             <DrawerContent>
               <DrawerHeader>

From f7e58e1aadde9f9b5b408a80cb719390de0969c7 Mon Sep 17 00:00:00 2001
From: Danielle Lindblom <danielle.lindblom@gmail.com>
Date: Wed, 8 Jan 2025 11:06:32 -0700
Subject: [PATCH 3/4] fix: address eslint issues with code formatting

---
 components/Nav/Nav.tsx             | 10 +++++-----
 components/NavDrawer/NavDrawer.tsx |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/components/Nav/Nav.tsx b/components/Nav/Nav.tsx
index 8798ad58..ede1e65e 100644
--- a/components/Nav/Nav.tsx
+++ b/components/Nav/Nav.tsx
@@ -62,13 +62,13 @@ export const Nav = (): JSX.Element => {
         <li>
           <Drawer open={open} onOpenChange={setOpen}>
             <DrawerTrigger 
-            data-testid="drawer-trigger"
-            aria-haspopup='menu'
-            aria-label='open navigation menu'
+              data-testid="drawer-trigger"
+              aria-haspopup='menu'
+              aria-label='open navigation menu'
             >
               <Menu 
-              className="text-foreground" 
-              aria-hidden='true'
+                className="text-foreground" 
+                aria-hidden='true'
               />
             </DrawerTrigger>
             <DrawerContent>
diff --git a/components/NavDrawer/NavDrawer.tsx b/components/NavDrawer/NavDrawer.tsx
index 6497026d..aae19431 100644
--- a/components/NavDrawer/NavDrawer.tsx
+++ b/components/NavDrawer/NavDrawer.tsx
@@ -130,7 +130,7 @@ const DrawerTitle = React.forwardRef<
 
     <DrawerClose aria-label='close navigation menu'>
       <X 
-      aria-hidden='true'
+        aria-hidden='true'
       />
     </DrawerClose>
   </div>

From b29351066577923915fa8d7f41ab3475fbdd231a Mon Sep 17 00:00:00 2001
From: Danielle Lindblom <danielle.lindblom@gmail.com>
Date: Tue, 14 Jan 2025 12:18:31 -0700
Subject: [PATCH 4/4] fix: keep original aria-haspopup='dialog' setting by
 removing override property, make aria-label for menu less verbose

---
 components/Nav/Nav.tsx | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/components/Nav/Nav.tsx b/components/Nav/Nav.tsx
index ede1e65e..233194be 100644
--- a/components/Nav/Nav.tsx
+++ b/components/Nav/Nav.tsx
@@ -63,8 +63,7 @@ export const Nav = (): JSX.Element => {
           <Drawer open={open} onOpenChange={setOpen}>
             <DrawerTrigger 
               data-testid="drawer-trigger"
-              aria-haspopup='menu'
-              aria-label='open navigation menu'
+              aria-label='menu'
             >
               <Menu 
                 className="text-foreground"