From 7e16ae1f5ba4a7a1d7ea3effd9ce983b75a301dd Mon Sep 17 00:00:00 2001 From: Manuel Martin Date: Wed, 24 Jul 2019 10:06:25 +0200 Subject: [PATCH] Awesome bar icons update --- .../mozilla/vrbrowser/ui/views/NavigationURLBar.java | 4 ++-- .../vrbrowser/ui/widgets/SuggestionsWidget.java | 4 ++-- app/src/main/res/drawable/ic_icon_bookmark.xml | 11 ++++++++--- app/src/main/res/drawable/ic_icon_bookmarked.xml | 4 ++++ ...kmark_active.xml => ic_icon_bookmarked_active.xml} | 0 app/src/main/res/drawable/ic_icon_globe.xml | 9 +++++++++ app/src/main/res/layout/navigation_url.xml | 2 +- 7 files changed, 26 insertions(+), 8 deletions(-) create mode 100644 app/src/main/res/drawable/ic_icon_bookmarked.xml rename app/src/main/res/drawable/{ic_icon_bookmark_active.xml => ic_icon_bookmarked_active.xml} (100%) create mode 100644 app/src/main/res/drawable/ic_icon_globe.xml diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/views/NavigationURLBar.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/views/NavigationURLBar.java index 194ed624d..c60ef8477 100644 --- a/app/src/common/shared/org/mozilla/vrbrowser/ui/views/NavigationURLBar.java +++ b/app/src/common/shared/org/mozilla/vrbrowser/ui/views/NavigationURLBar.java @@ -238,9 +238,9 @@ private void handleBookmarkClick() { private void setBookmarked(boolean aValue) { if (aValue) { - mBookmarkButton.setImageDrawable(getContext().getDrawable(R.drawable.ic_icon_bookmark_active)); + mBookmarkButton.setImageDrawable(getContext().getDrawable(R.drawable.ic_icon_bookmarked_active)); } else { - mBookmarkButton.setImageDrawable(getContext().getDrawable(R.drawable.ic_icon_bookmark)); + mBookmarkButton.setImageDrawable(getContext().getDrawable(R.drawable.ic_icon_bookmarked)); } } diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/SuggestionsWidget.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/SuggestionsWidget.java index 861b9bf48..a0290fc8f 100644 --- a/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/SuggestionsWidget.java +++ b/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/SuggestionsWidget.java @@ -256,11 +256,11 @@ public View getView(int position, View convertView, ViewGroup parent) { if (selectedItem.type == SuggestionItem.Type.SUGGESTION) itemViewHolder.favicon.setImageResource(R.drawable.ic_icon_search); else if (selectedItem.type == SuggestionItem.Type.COMPLETION) - itemViewHolder.favicon.setImageResource(R.drawable.ic_icon_browser); + itemViewHolder.favicon.setImageResource(R.drawable.ic_icon_globe); else if (selectedItem.type == SuggestionItem.Type.HISTORY) itemViewHolder.favicon.setImageResource(R.drawable.ic_icon_history); else if (selectedItem.type == SuggestionItem.Type.BOOKMARK) - itemViewHolder.favicon.setImageResource(R.drawable.ic_icon_bookmark_active); + itemViewHolder.favicon.setImageResource(R.drawable.ic_icon_bookmark); itemViewHolder.delete.setVisibility(GONE); itemViewHolder.favicon.setVisibility(VISIBLE); diff --git a/app/src/main/res/drawable/ic_icon_bookmark.xml b/app/src/main/res/drawable/ic_icon_bookmark.xml index 50b9a8139..29364bf70 100644 --- a/app/src/main/res/drawable/ic_icon_bookmark.xml +++ b/app/src/main/res/drawable/ic_icon_bookmark.xml @@ -1,4 +1,9 @@ - - + + diff --git a/app/src/main/res/drawable/ic_icon_bookmarked.xml b/app/src/main/res/drawable/ic_icon_bookmarked.xml new file mode 100644 index 000000000..50b9a8139 --- /dev/null +++ b/app/src/main/res/drawable/ic_icon_bookmarked.xml @@ -0,0 +1,4 @@ + + + diff --git a/app/src/main/res/drawable/ic_icon_bookmark_active.xml b/app/src/main/res/drawable/ic_icon_bookmarked_active.xml similarity index 100% rename from app/src/main/res/drawable/ic_icon_bookmark_active.xml rename to app/src/main/res/drawable/ic_icon_bookmarked_active.xml diff --git a/app/src/main/res/drawable/ic_icon_globe.xml b/app/src/main/res/drawable/ic_icon_globe.xml new file mode 100644 index 000000000..1ed072f72 --- /dev/null +++ b/app/src/main/res/drawable/ic_icon_globe.xml @@ -0,0 +1,9 @@ + + + diff --git a/app/src/main/res/layout/navigation_url.xml b/app/src/main/res/layout/navigation_url.xml index c4a635c6c..fb58aadfd 100644 --- a/app/src/main/res/layout/navigation_url.xml +++ b/app/src/main/res/layout/navigation_url.xml @@ -72,7 +72,7 @@