diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/views/settings/SwitchSetting.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/views/settings/SwitchSetting.java index eabf4b821..2da94e8f9 100644 --- a/app/src/common/shared/org/mozilla/vrbrowser/ui/views/settings/SwitchSetting.java +++ b/app/src/common/shared/org/mozilla/vrbrowser/ui/views/settings/SwitchSetting.java @@ -122,4 +122,8 @@ public void setHelpDelegate(Runnable aDelegate) { } } + public void setDescription(@NonNull String description) { + mSwitchDescription.setText(description); + } + } diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WindowWidget.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WindowWidget.java index 8ac7f6e41..50a201edd 100644 --- a/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WindowWidget.java +++ b/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WindowWidget.java @@ -737,17 +737,7 @@ public void showButtonPrompt(String title, @NonNull String msg, @NonNull String[ mConfirmPrompt.show(REQUEST_FOCUS); } - public void showAppDialog(@NonNull @StringRes int title, @NonNull @StringRes int description, @NonNull @StringRes int [] btnMsg, @NonNull AppDialogWidget.Delegate callback) { - mAppDialog = new AppDialogWidget(getContext()); - mAppDialog.mWidgetPlacement.parentHandle = getHandle(); - mAppDialog.setTitle(title); - mAppDialog.setMessage(description); - mAppDialog.setButtons(btnMsg); - mAppDialog.setDelegate(callback); - mAppDialog.show(REQUEST_FOCUS); - } - - public void showAppDialog(@NonNull String title, @NonNull String description, @NonNull String[] btnMsg, @NonNull AppDialogWidget.Delegate callback) { + public void showAppDialog(@NonNull String title, @NonNull @StringRes int description, @NonNull @StringRes int [] btnMsg, @NonNull AppDialogWidget.Delegate callback) { mAppDialog = new AppDialogWidget(getContext()); mAppDialog.mWidgetPlacement.parentHandle = getHandle(); mAppDialog.setTitle(title); diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/dialogs/VoiceSearchWidget.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/dialogs/VoiceSearchWidget.java index 7806098db..e41291424 100644 --- a/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/dialogs/VoiceSearchWidget.java +++ b/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/dialogs/VoiceSearchWidget.java @@ -286,7 +286,7 @@ public void show(@ShowFlags int aShowFlags) { } else { mWidgetManager.getFocusedWindow().showAppDialog( - R.string.voice_samples_collect_dialog_title, + getResources().getString(R.string.voice_samples_collect_data_dialog_title, getResources().getString(R.string.app_name)), R.string.voice_samples_collect_dialog_description, new int[]{ R.string.voice_samples_collect_dialog_do_not_allow, diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/settings/SettingsHeader.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/settings/SettingsHeader.java index b32a81774..220dfcae0 100644 --- a/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/settings/SettingsHeader.java +++ b/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/settings/SettingsHeader.java @@ -81,4 +81,8 @@ public void setHelpClickListener(@NonNull View.OnClickListener listener) { mBinding.setHelpClickListener(listener); } + public void setTitle(@NonNull String title) { + mBinding.setTitle(title); + } + } diff --git a/app/src/main/res/layout/options_language_display.xml b/app/src/main/res/layout/options_language_display.xml index dc0544996..4a94887c8 100644 --- a/app/src/main/res/layout/options_language_display.xml +++ b/app/src/main/res/layout/options_language_display.xml @@ -18,7 +18,7 @@ app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toTopOf="parent" - app:title="@string/settings_language_choose_language_display_title" /> + app:title="@{String.format(@string/settings_language_choose_display_language_title, @string/app_name)}" /> + android:text="@{String.format(@string/security_options_speech_data_collection_title, @string/app_name)}" /> + app:description="@{String.format(@string/security_options_speech_data_collect, @string/app_name)}" /> + app:description="@{String.format(@string/security_options_telemetry_send_data, @string/app_name)}" /> + app:description="@{String.format(@string/security_options_crash_reports_send_data, @string/app_name)}" /> diff --git a/app/src/main/res/layout/setting_switch.xml b/app/src/main/res/layout/setting_switch.xml index 75785f2b9..acf7789f9 100644 --- a/app/src/main/res/layout/setting_switch.xml +++ b/app/src/main/res/layout/setting_switch.xml @@ -22,6 +22,7 @@ diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index f6b4d9438..989aaccb8 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -141,7 +141,7 @@ 'Firefox Display Language' dialog window (accessible from the browser's Settings dialog window). Below this string appears a list of locales for the user to choose as their preferred display language for the application UI. --> - Firefox Display Language + %1$s Display Language - Firefox Data Collection and Use + %1$s Data Collection and Use - Allow Firefox to collect speech data + Allow %1$s to collect speech data - Allow Firefox to send technical and interaction data to Mozilla + Allow %1$s to send technical and interaction data to Mozilla - Allow Firefox to send backlogged crash reports on your behalf + Allow %1$s to send backlogged crash reports on your behalf @@ -860,7 +860,7 @@ - Allow Firefox Reality to Collect Voice Samples for Research? + Allow %1$s to Collect Voice Samples for Research?