From ce476df43dd8d438d52c4e1ca966dbc16a370b54 Mon Sep 17 00:00:00 2001
From: Manuel Martin <manmartin@mozilla.com>
Date: Mon, 2 Sep 2019 12:02:03 +0200
Subject: [PATCH 1/3] Fix for the fullscreen controls middle gap between
 buttons

---
 app/src/main/res/layout/navigation_bar.xml     | 13 ++++---------
 .../res/layout/navigation_bar_fullscreen.xml   | 18 ++++++++++--------
 .../main/res/layout/navigation_bar_resize.xml  |  8 +++-----
 3 files changed, 17 insertions(+), 22 deletions(-)

diff --git a/app/src/main/res/layout/navigation_bar.xml b/app/src/main/res/layout/navigation_bar.xml
index 8d269b996..a7ca4aa7f 100644
--- a/app/src/main/res/layout/navigation_bar.xml
+++ b/app/src/main/res/layout/navigation_bar.xml
@@ -1,14 +1,9 @@
 <?xml version="1.0" encoding="utf-8"?>
-<merge xmlns:android="http://schemas.android.com/apk/res/android">
+<merge>
 
-    <RelativeLayout
-        android:layout_width="match_parent"
-        android:layout_height="40dp">
+    <include layout="@layout/navigation_bar_navigation" />
 
-        <include layout="@layout/navigation_bar_navigation" />
+    <include layout="@layout/navigation_bar_fullscreen" />
 
-        <include layout="@layout/navigation_bar_fullscreen" />
-
-        <include layout="@layout/navigation_bar_resize" />
-    </RelativeLayout>
+    <include layout="@layout/navigation_bar_resize" />
 </merge>
diff --git a/app/src/main/res/layout/navigation_bar_fullscreen.xml b/app/src/main/res/layout/navigation_bar_fullscreen.xml
index 1dc2f3f9d..2a8793304 100644
--- a/app/src/main/res/layout/navigation_bar_fullscreen.xml
+++ b/app/src/main/res/layout/navigation_bar_fullscreen.xml
@@ -3,24 +3,25 @@
 
     <LinearLayout
         android:id="@+id/fullScreenModeContainer"
-        style="?attr/navigationBarStyle"
-        android:layout_width="match_parent"
-        android:layout_height="match_parent"
-        android:gravity="center_horizontal"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:layout_gravity="center"
         android:orientation="horizontal"
-        android:padding="0dp"
+        android:paddingStart="1dp"
         android:visibility="gone">
 
         <org.mozilla.vrbrowser.ui.views.UIButton
             android:id="@+id/fullScreenExitButton"
             style="?attr/fullScreenButtonStyle"
             android:background="@drawable/fullscreen_button_first"
-            android:src="@drawable/ic_icon_back" />
+            android:src="@drawable/ic_icon_back"
+            android:tooltipText="@string/back_tooltip"/>
 
         <org.mozilla.vrbrowser.ui.views.UIButton
             android:id="@+id/fullScreenResizeEnterButton"
             style="?attr/fullScreenButtonStyle"
-            android:src="@drawable/ic_icon_resize" />
+            android:src="@drawable/ic_icon_resize"
+            android:tooltipText="@string/resize_tooltip"/>
 
         <org.mozilla.vrbrowser.ui.views.UIButton
             android:id="@+id/projectionButton"
@@ -32,6 +33,7 @@
             android:id="@+id/brightnessButton"
             style="?attr/fullScreenButtonStyle"
             android:background="@drawable/fullscreen_button_last"
-            android:src="@drawable/ic_icon_brightness" />
+            android:src="@drawable/ic_icon_brightness"
+            android:tooltipText="@string/brightness_mode_tooltip"/>
     </LinearLayout>
 </merge>
\ No newline at end of file
diff --git a/app/src/main/res/layout/navigation_bar_resize.xml b/app/src/main/res/layout/navigation_bar_resize.xml
index 06be11ced..57d4da1c5 100644
--- a/app/src/main/res/layout/navigation_bar_resize.xml
+++ b/app/src/main/res/layout/navigation_bar_resize.xml
@@ -3,12 +3,10 @@
 
     <LinearLayout
         android:id="@+id/resizeModeContainer"
-        style="?attr/navigationBarStyle"
-        android:layout_width="match_parent"
-        android:layout_height="match_parent"
-        android:gravity="center_horizontal"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:layout_gravity="center"
         android:orientation="horizontal"
-        android:padding="0dp"
         android:visibility="gone">
 
         <org.mozilla.vrbrowser.ui.views.UITextButton

From 63878437af250eea170e399e6a1e14392aa78db9 Mon Sep 17 00:00:00 2001
From: Manuel Martin <manmartin@mozilla.com>
Date: Mon, 2 Sep 2019 12:26:06 +0200
Subject: [PATCH 2/3] Added a padding to fix the gap

---
 app/src/main/res/layout/navigation_bar_fullscreen.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/src/main/res/layout/navigation_bar_fullscreen.xml b/app/src/main/res/layout/navigation_bar_fullscreen.xml
index 2a8793304..15fc0582d 100644
--- a/app/src/main/res/layout/navigation_bar_fullscreen.xml
+++ b/app/src/main/res/layout/navigation_bar_fullscreen.xml
@@ -7,7 +7,7 @@
         android:layout_height="wrap_content"
         android:layout_gravity="center"
         android:orientation="horizontal"
-        android:paddingStart="1dp"
+        android:paddingStart="2dp"
         android:visibility="gone">
 
         <org.mozilla.vrbrowser.ui.views.UIButton

From 4f1e0492f0aad06dc2f8a2e197d2b4be201ce125 Mon Sep 17 00:00:00 2001
From: Manuel Martin <manmartin@mozilla.com>
Date: Mon, 2 Sep 2019 18:12:54 +0200
Subject: [PATCH 3/3] Add a background layout to cover the gap

---
 .../res/layout/navigation_bar_fullscreen.xml  | 63 +++++++++++--------
 1 file changed, 37 insertions(+), 26 deletions(-)

diff --git a/app/src/main/res/layout/navigation_bar_fullscreen.xml b/app/src/main/res/layout/navigation_bar_fullscreen.xml
index 15fc0582d..e53bdb6df 100644
--- a/app/src/main/res/layout/navigation_bar_fullscreen.xml
+++ b/app/src/main/res/layout/navigation_bar_fullscreen.xml
@@ -1,39 +1,50 @@
 <?xml version="1.0" encoding="utf-8"?>
 <merge xmlns:android="http://schemas.android.com/apk/res/android">
 
-    <LinearLayout
+    <FrameLayout
         android:id="@+id/fullScreenModeContainer"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_gravity="center"
-        android:orientation="horizontal"
-        android:paddingStart="2dp"
         android:visibility="gone">
 
-        <org.mozilla.vrbrowser.ui.views.UIButton
-            android:id="@+id/fullScreenExitButton"
-            style="?attr/fullScreenButtonStyle"
-            android:background="@drawable/fullscreen_button_first"
-            android:src="@drawable/ic_icon_back"
-            android:tooltipText="@string/back_tooltip"/>
+        <FrameLayout
+            android:layout_width="5dp"
+            android:layout_height="40dp"
+            android:layout_gravity="center"
+            android:background="@drawable/fullscreen_button" />
 
-        <org.mozilla.vrbrowser.ui.views.UIButton
-            android:id="@+id/fullScreenResizeEnterButton"
-            style="?attr/fullScreenButtonStyle"
-            android:src="@drawable/ic_icon_resize"
-            android:tooltipText="@string/resize_tooltip"/>
+        <LinearLayout
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_gravity="center"
+            android:orientation="horizontal">
 
-        <org.mozilla.vrbrowser.ui.views.UIButton
-            android:id="@+id/projectionButton"
-            style="?attr/fullScreenButtonStyle"
-            android:src="@drawable/ic_icon_vr_projection"
-            android:tooltipText="@string/video_mode_tooltip" />
+            <org.mozilla.vrbrowser.ui.views.UIButton
+                android:id="@+id/fullScreenExitButton"
+                style="?attr/fullScreenButtonStyle"
+                android:background="@drawable/fullscreen_button_first"
+                android:src="@drawable/ic_icon_back"
+                android:tooltipText="@string/back_tooltip" />
 
-        <org.mozilla.vrbrowser.ui.views.UIButton
-            android:id="@+id/brightnessButton"
-            style="?attr/fullScreenButtonStyle"
-            android:background="@drawable/fullscreen_button_last"
-            android:src="@drawable/ic_icon_brightness"
-            android:tooltipText="@string/brightness_mode_tooltip"/>
-    </LinearLayout>
+            <org.mozilla.vrbrowser.ui.views.UIButton
+                android:id="@+id/fullScreenResizeEnterButton"
+                style="?attr/fullScreenButtonStyle"
+                android:src="@drawable/ic_icon_resize"
+                android:tooltipText="@string/resize_tooltip" />
+
+            <org.mozilla.vrbrowser.ui.views.UIButton
+                android:id="@+id/projectionButton"
+                style="?attr/fullScreenButtonStyle"
+                android:src="@drawable/ic_icon_vr_projection"
+                android:tooltipText="@string/video_mode_tooltip" />
+
+            <org.mozilla.vrbrowser.ui.views.UIButton
+                android:id="@+id/brightnessButton"
+                style="?attr/fullScreenButtonStyle"
+                android:background="@drawable/fullscreen_button_last"
+                android:src="@drawable/ic_icon_brightness"
+                android:tooltipText="@string/brightness_mode_tooltip" />
+        </LinearLayout>
+    </FrameLayout>
 </merge>
\ No newline at end of file