[FIX] hr_timesheet_sheet_attendance: allow checking out to plain atte…#907
Open
blaskurain wants to merge 1 commit into
Open
[FIX] hr_timesheet_sheet_attendance: allow checking out to plain atte…#907blaskurain wants to merge 1 commit into
blaskurain wants to merge 1 commit into
Conversation
…ndance users The previous version, implemented around _attendance_action_change, allowed checking in but not checking out, which raised a permission denied error. Using attendance_manual takes care of the permission issues and also avoid depending on a private function.
OCA-git-bot
added
mod:hr_timesheet_sheet_attendance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ndance users
The previous version, implemented around _attendance_action_change, allowed checking in but not checking out, which raised a permission denied error. Using attendance_manual takes care of the permission issues and also avoid depending on a private function.