diff --git a/hr_timesheet_sheet_policy_project_manager/README.rst b/hr_timesheet_sheet_policy_project_manager/README.rst new file mode 100644 index 0000000000..2ca7014ce8 --- /dev/null +++ b/hr_timesheet_sheet_policy_project_manager/README.rst @@ -0,0 +1,98 @@ +.. image:: https://odoo-community.org/readme-banner-image + :target: https://odoo-community.org/get-involved?utm_source=readme + :alt: Odoo Community Association + +========================================== +HR Timesheet Sheet: Project Manager Policy +========================================== + +.. + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! This file is generated by oca-gen-addon-readme !! + !! changes will be overwritten. !! + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! source digest: sha256:f3f1a519f6fc46cf06ceeee534d2b605f7bb3f712a85978b423f5938bfb26112 + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + +.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png + :target: https://odoo-community.org/page/development-status + :alt: Beta +.. |badge2| image:: https://img.shields.io/badge/license-AGPL--3-blue.png + :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html + :alt: License: AGPL-3 +.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Ftimesheet-lightgray.png?logo=github + :target: https://github.com/OCA/timesheet/tree/19.0/hr_timesheet_sheet_policy_project_manager + :alt: OCA/timesheet +.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png + :target: https://translation.odoo-community.org/projects/timesheet-19-0/timesheet-19-0-hr_timesheet_sheet_policy_project_manager + :alt: Translate me on Weblate +.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png + :target: https://runboat.odoo-community.org/builds?repo=OCA/timesheet&target_branch=19.0 + :alt: Try me on Runboat + +|badge1| |badge2| |badge3| |badge4| |badge5| + +This module allows setting Department Manager as Reviewer on Timesheet +Sheets. + +**Table of contents** + +.. contents:: + :local: + +Configuration +============= + +Go to Timesheets > Configuration > Timesheet Options > Timesheet Sheet +Review Policy and select the option "By Project Manager". + +Usage +===== + +- The "Project" field is added to the Timesheet Sheets. +- The records that will be created in the sheets will be filtered by the + defined project. +- The possible reviewers will also be the Project Managers of the + corresponding project. + +Bug Tracker +=========== + +Bugs are tracked on `GitHub Issues `_. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +`feedback `_. + +Do not contact contributors directly about support or help with technical issues. + +Credits +======= + +Authors +------- + +* CorporateHub + +Contributors +------------ + +- `CorporateHub `__ + + - Alexey Pelykh + +Maintainers +----------- + +This module is maintained by the OCA. + +.. image:: https://odoo-community.org/logo.png + :alt: Odoo Community Association + :target: https://odoo-community.org + +OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use. + +This module is part of the `OCA/timesheet `_ project on GitHub. + +You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. diff --git a/hr_timesheet_sheet_policy_project_manager/__init__.py b/hr_timesheet_sheet_policy_project_manager/__init__.py new file mode 100644 index 0000000000..31660d6a96 --- /dev/null +++ b/hr_timesheet_sheet_policy_project_manager/__init__.py @@ -0,0 +1,3 @@ +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from . import models diff --git a/hr_timesheet_sheet_policy_project_manager/__manifest__.py b/hr_timesheet_sheet_policy_project_manager/__manifest__.py new file mode 100644 index 0000000000..5e9c723cac --- /dev/null +++ b/hr_timesheet_sheet_policy_project_manager/__manifest__.py @@ -0,0 +1,16 @@ +# Copyright 2019 Brainbean Apps (https://brainbeanapps.com) +# Copyright 2020 CorporateHub (https://corporatehub.eu) +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +{ + "name": "HR Timesheet Sheet: Project Manager Policy", + "version": "19.0.1.0.0", + "author": "CorporateHub, Odoo Community Association (OCA)", + "website": "https://github.com/OCA/timesheet", + "license": "AGPL-3", + "category": "Human Resources", + "summary": "Allows setting Project Manager as Reviewer", + "depends": ["hr_timesheet_sheet"], + "data": ["views/hr_timesheet_sheet.xml"], + "installable": True, +} diff --git a/hr_timesheet_sheet_policy_project_manager/i18n/es.po b/hr_timesheet_sheet_policy_project_manager/i18n/es.po new file mode 100644 index 0000000000..80e7a66a60 --- /dev/null +++ b/hr_timesheet_sheet_policy_project_manager/i18n/es.po @@ -0,0 +1,76 @@ +# Translation of Odoo Server. +# This file contains the translation of the following modules: +# * hr_timesheet_sheet_policy_project_manager +# +msgid "" +msgstr "" +"Project-Id-Version: Odoo Server 12.0\n" +"Report-Msgid-Bugs-To: \n" +"PO-Revision-Date: 2020-05-18 20:19+0000\n" +"Last-Translator: Josep M \n" +"Language-Team: none\n" +"Language: es\n" +"MIME-Version: 1.0\n" +"Content-Type: text/plain; charset=UTF-8\n" +"Content-Transfer-Encoding: \n" +"Plural-Forms: nplurals=2; plural=n != 1;\n" +"X-Generator: Weblate 3.10\n" + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model,name:hr_timesheet_sheet_policy_project_manager.model_account_analytic_line +msgid "Analytic Line" +msgstr "Línea analítica" + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model.fields.selection,name:hr_timesheet_sheet_policy_project_manager.selection__res_company__timesheet_sheet_review_policy__project_manager +msgid "By Project Manager" +msgstr "Por responsable de proyecto" + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model,name:hr_timesheet_sheet_policy_project_manager.model_res_company +msgid "Companies" +msgstr "Compañías" + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model.fields,help:hr_timesheet_sheet_policy_project_manager.field_res_company__timesheet_sheet_review_policy +msgid "How Timesheet Sheets review is performed." +msgstr "Cómo ser realiza la revisión de Partes de horas." + +#. module: hr_timesheet_sheet_policy_project_manager +#. odoo-python +#: code:addons/hr_timesheet_sheet_policy_project_manager/models/hr_timesheet_sheet.py:0 +#, python-format +msgid "Only a Project Manager can review the sheet." +msgstr "Solo un responsable de proyecto puede revisar el parte." + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model.fields,field_description:hr_timesheet_sheet_policy_project_manager.field_hr_timesheet_sheet__project_id +#: model_terms:ir.ui.view,arch_db:hr_timesheet_sheet_policy_project_manager.view_hr_timesheet_sheet_filter +msgid "Project" +msgstr "Proyecto" + +#. module: hr_timesheet_sheet_policy_project_manager +#. odoo-python +#: code:addons/hr_timesheet_sheet_policy_project_manager/models/hr_timesheet_sheet.py:0 +#, python-format +msgid "Review policy \"By Project Manager\" requires Project to be set" +msgstr "" +"La política de revisión \"Por Project Manager\" requiere que se configure en " +"el proyecto" + +#. module: hr_timesheet_sheet_policy_project_manager +#. odoo-python +#: code:addons/hr_timesheet_sheet_policy_project_manager/models/hr_timesheet_sheet.py:0 +#, python-format +msgid "The Company in the Timesheet Sheet and in the Project must be the same." +msgstr "La empresa en el parte de horas y en el proyecto deben ser la misma." + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model,name:hr_timesheet_sheet_policy_project_manager.model_hr_timesheet_sheet +msgid "Timesheet Sheet" +msgstr "Parte de horas" + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model.fields,field_description:hr_timesheet_sheet_policy_project_manager.field_res_company__timesheet_sheet_review_policy +msgid "Timesheet Sheet Review Policy" +msgstr "Política de revisión de Parte de horas" diff --git a/hr_timesheet_sheet_policy_project_manager/i18n/hr_timesheet_sheet_policy_project_manager.pot b/hr_timesheet_sheet_policy_project_manager/i18n/hr_timesheet_sheet_policy_project_manager.pot new file mode 100644 index 0000000000..a358066d72 --- /dev/null +++ b/hr_timesheet_sheet_policy_project_manager/i18n/hr_timesheet_sheet_policy_project_manager.pot @@ -0,0 +1,69 @@ +# Translation of Odoo Server. +# This file contains the translation of the following modules: +# * hr_timesheet_sheet_policy_project_manager +# +msgid "" +msgstr "" +"Project-Id-Version: Odoo Server 18.0\n" +"Report-Msgid-Bugs-To: \n" +"Last-Translator: \n" +"Language-Team: \n" +"MIME-Version: 1.0\n" +"Content-Type: text/plain; charset=UTF-8\n" +"Content-Transfer-Encoding: \n" +"Plural-Forms: \n" + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model,name:hr_timesheet_sheet_policy_project_manager.model_account_analytic_line +msgid "Analytic Line" +msgstr "" + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model.fields.selection,name:hr_timesheet_sheet_policy_project_manager.selection__res_company__timesheet_sheet_review_policy__project_manager +msgid "By Project Manager" +msgstr "" + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model,name:hr_timesheet_sheet_policy_project_manager.model_res_company +msgid "Companies" +msgstr "" + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model.fields,help:hr_timesheet_sheet_policy_project_manager.field_res_company__timesheet_sheet_review_policy +msgid "How Timesheet Sheets review is performed." +msgstr "" + +#. module: hr_timesheet_sheet_policy_project_manager +#. odoo-python +#: code:addons/hr_timesheet_sheet_policy_project_manager/models/hr_timesheet_sheet.py:0 +msgid "Only a Project Manager can review the sheet." +msgstr "" + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model.fields,field_description:hr_timesheet_sheet_policy_project_manager.field_hr_timesheet_sheet__project_id +#: model_terms:ir.ui.view,arch_db:hr_timesheet_sheet_policy_project_manager.view_hr_timesheet_sheet_filter +msgid "Project" +msgstr "" + +#. module: hr_timesheet_sheet_policy_project_manager +#. odoo-python +#: code:addons/hr_timesheet_sheet_policy_project_manager/models/hr_timesheet_sheet.py:0 +msgid "Review policy \"By Project Manager\" requires Project to be set" +msgstr "" + +#. module: hr_timesheet_sheet_policy_project_manager +#. odoo-python +#: code:addons/hr_timesheet_sheet_policy_project_manager/models/hr_timesheet_sheet.py:0 +msgid "" +"The Company in the Timesheet Sheet and in the Project must be the same." +msgstr "" + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model,name:hr_timesheet_sheet_policy_project_manager.model_hr_timesheet_sheet +msgid "Timesheet Sheet" +msgstr "" + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model.fields,field_description:hr_timesheet_sheet_policy_project_manager.field_res_company__timesheet_sheet_review_policy +msgid "Timesheet Sheet Review Policy" +msgstr "" diff --git a/hr_timesheet_sheet_policy_project_manager/i18n/it.po b/hr_timesheet_sheet_policy_project_manager/i18n/it.po new file mode 100644 index 0000000000..50e0cc5671 --- /dev/null +++ b/hr_timesheet_sheet_policy_project_manager/i18n/it.po @@ -0,0 +1,76 @@ +# Translation of Odoo Server. +# This file contains the translation of the following modules: +# * hr_timesheet_sheet_policy_project_manager +# +msgid "" +msgstr "" +"Project-Id-Version: Odoo Server 14.0\n" +"Report-Msgid-Bugs-To: \n" +"PO-Revision-Date: 2023-10-10 16:37+0000\n" +"Last-Translator: mymage \n" +"Language-Team: none\n" +"Language: it\n" +"MIME-Version: 1.0\n" +"Content-Type: text/plain; charset=UTF-8\n" +"Content-Transfer-Encoding: \n" +"Plural-Forms: nplurals=2; plural=n != 1;\n" +"X-Generator: Weblate 4.17\n" + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model,name:hr_timesheet_sheet_policy_project_manager.model_account_analytic_line +msgid "Analytic Line" +msgstr "Riga analitica" + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model.fields.selection,name:hr_timesheet_sheet_policy_project_manager.selection__res_company__timesheet_sheet_review_policy__project_manager +msgid "By Project Manager" +msgstr "Da responsabile progetto" + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model,name:hr_timesheet_sheet_policy_project_manager.model_res_company +msgid "Companies" +msgstr "Aziende" + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model.fields,help:hr_timesheet_sheet_policy_project_manager.field_res_company__timesheet_sheet_review_policy +msgid "How Timesheet Sheets review is performed." +msgstr "Come viene eseguita la revisione dei prospetti fogli ore." + +#. module: hr_timesheet_sheet_policy_project_manager +#. odoo-python +#: code:addons/hr_timesheet_sheet_policy_project_manager/models/hr_timesheet_sheet.py:0 +#, python-format +msgid "Only a Project Manager can review the sheet." +msgstr "Solo un responsabile progetto può revisionare il prospetto." + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model.fields,field_description:hr_timesheet_sheet_policy_project_manager.field_hr_timesheet_sheet__project_id +#: model_terms:ir.ui.view,arch_db:hr_timesheet_sheet_policy_project_manager.view_hr_timesheet_sheet_filter +msgid "Project" +msgstr "Progetto" + +#. module: hr_timesheet_sheet_policy_project_manager +#. odoo-python +#: code:addons/hr_timesheet_sheet_policy_project_manager/models/hr_timesheet_sheet.py:0 +#, python-format +msgid "Review policy \"By Project Manager\" requires Project to be set" +msgstr "" +"La politica di revisione \"Da responsabile progetto\" richiede che sia " +"impostato il progetto" + +#. module: hr_timesheet_sheet_policy_project_manager +#. odoo-python +#: code:addons/hr_timesheet_sheet_policy_project_manager/models/hr_timesheet_sheet.py:0 +#, python-format +msgid "The Company in the Timesheet Sheet and in the Project must be the same." +msgstr "L'azienda del prospetto foglio ore e del progetto devono corrispondere." + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model,name:hr_timesheet_sheet_policy_project_manager.model_hr_timesheet_sheet +msgid "Timesheet Sheet" +msgstr "Prospetto foglio ore" + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model.fields,field_description:hr_timesheet_sheet_policy_project_manager.field_res_company__timesheet_sheet_review_policy +msgid "Timesheet Sheet Review Policy" +msgstr "Politica revisione prospetto foglio ore" diff --git a/hr_timesheet_sheet_policy_project_manager/i18n/pt_BR.po b/hr_timesheet_sheet_policy_project_manager/i18n/pt_BR.po new file mode 100644 index 0000000000..15ee550dbe --- /dev/null +++ b/hr_timesheet_sheet_policy_project_manager/i18n/pt_BR.po @@ -0,0 +1,77 @@ +# Translation of Odoo Server. +# This file contains the translation of the following modules: +# * hr_timesheet_sheet_policy_project_manager +# +msgid "" +msgstr "" +"Project-Id-Version: Odoo Server 16.0\n" +"Report-Msgid-Bugs-To: \n" +"PO-Revision-Date: 2023-10-27 21:25+0000\n" +"Last-Translator: Adriano Prado \n" +"Language-Team: none\n" +"Language: pt_BR\n" +"MIME-Version: 1.0\n" +"Content-Type: text/plain; charset=UTF-8\n" +"Content-Transfer-Encoding: \n" +"Plural-Forms: nplurals=2; plural=n > 1;\n" +"X-Generator: Weblate 4.17\n" + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model,name:hr_timesheet_sheet_policy_project_manager.model_account_analytic_line +msgid "Analytic Line" +msgstr "Linha Analítica" + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model.fields.selection,name:hr_timesheet_sheet_policy_project_manager.selection__res_company__timesheet_sheet_review_policy__project_manager +msgid "By Project Manager" +msgstr "Por Gerente Projeto" + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model,name:hr_timesheet_sheet_policy_project_manager.model_res_company +msgid "Companies" +msgstr "Empresas" + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model.fields,help:hr_timesheet_sheet_policy_project_manager.field_res_company__timesheet_sheet_review_policy +msgid "How Timesheet Sheets review is performed." +msgstr "Como é realizada a revisão das Planilhas de Horas." + +#. module: hr_timesheet_sheet_policy_project_manager +#. odoo-python +#: code:addons/hr_timesheet_sheet_policy_project_manager/models/hr_timesheet_sheet.py:0 +#, python-format +msgid "Only a Project Manager can review the sheet." +msgstr "Somente um gerente de projeto pode revisar a planilha." + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model.fields,field_description:hr_timesheet_sheet_policy_project_manager.field_hr_timesheet_sheet__project_id +#: model_terms:ir.ui.view,arch_db:hr_timesheet_sheet_policy_project_manager.view_hr_timesheet_sheet_filter +msgid "Project" +msgstr "Projeto" + +#. module: hr_timesheet_sheet_policy_project_manager +#. odoo-python +#: code:addons/hr_timesheet_sheet_policy_project_manager/models/hr_timesheet_sheet.py:0 +#, python-format +msgid "Review policy \"By Project Manager\" requires Project to be set" +msgstr "" +"A política de revisão \"Por Gerente de Projeto\" exige que o Projeto seja " +"definido" + +#. module: hr_timesheet_sheet_policy_project_manager +#. odoo-python +#: code:addons/hr_timesheet_sheet_policy_project_manager/models/hr_timesheet_sheet.py:0 +#, python-format +msgid "" +"The Company in the Timesheet Sheet and in the Project must be the same." +msgstr "A Empresa na Planilha de Horas e no Projeto deve ser a mesma." + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model,name:hr_timesheet_sheet_policy_project_manager.model_hr_timesheet_sheet +msgid "Timesheet Sheet" +msgstr "Planilha de Horas" + +#. module: hr_timesheet_sheet_policy_project_manager +#: model:ir.model.fields,field_description:hr_timesheet_sheet_policy_project_manager.field_res_company__timesheet_sheet_review_policy +msgid "Timesheet Sheet Review Policy" +msgstr "Politica de Revisão da Planilha de Horas" diff --git a/hr_timesheet_sheet_policy_project_manager/models/__init__.py b/hr_timesheet_sheet_policy_project_manager/models/__init__.py new file mode 100644 index 0000000000..e9063b6e39 --- /dev/null +++ b/hr_timesheet_sheet_policy_project_manager/models/__init__.py @@ -0,0 +1,5 @@ +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from . import account_analytic_line +from . import hr_timesheet_sheet +from . import res_company diff --git a/hr_timesheet_sheet_policy_project_manager/models/account_analytic_line.py b/hr_timesheet_sheet_policy_project_manager/models/account_analytic_line.py new file mode 100644 index 0000000000..6125a9ca81 --- /dev/null +++ b/hr_timesheet_sheet_policy_project_manager/models/account_analytic_line.py @@ -0,0 +1,14 @@ +# Copyright 2019 Brainbean Apps (https://brainbeanapps.com) +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html). + +from odoo import models + + +class AccountAnalyticLine(models.Model): + _inherit = "account.analytic.line" + + def _get_sheet_domain(self): + domain = super()._get_sheet_domain() + if self.company_id.timesheet_sheet_review_policy == "project_manager": + domain += [("project_id", "=", self.project_id.id)] + return domain diff --git a/hr_timesheet_sheet_policy_project_manager/models/hr_timesheet_sheet.py b/hr_timesheet_sheet_policy_project_manager/models/hr_timesheet_sheet.py new file mode 100644 index 0000000000..1dd701e89a --- /dev/null +++ b/hr_timesheet_sheet_policy_project_manager/models/hr_timesheet_sheet.py @@ -0,0 +1,98 @@ +# Copyright 2019 Brainbean Apps (https://brainbeanapps.com) +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html). + +from odoo import api, fields, models +from odoo.exceptions import UserError, ValidationError + + +class HrTimesheetSheet(models.Model): + _inherit = "hr_timesheet.sheet" + + project_id = fields.Many2one( + string="Project", + comodel_name="project.project", + domain="[('company_id', '=', company_id)]", + ) + + def _get_complete_name_components(self): + self.ensure_one() + result = super()._get_complete_name_components() + if self.review_policy == "project_manager" and self.project_id: + result += [self.project_id.display_name] + return result + + def _get_overlapping_sheet_domain(self): + domain = super()._get_overlapping_sheet_domain() + if self.review_policy == "project_manager" and self.project_id: + domain += [("project_id", "=", self.project_id.id)] + return domain + + @api.constrains( + "date_start", + "date_end", + "company_id", + "employee_id", + "review_policy", + "project_id", + ) + def _check_overlapping_sheets_project_id(self): + self._check_overlapping_sheets() + + @api.constrains("company_id", "project_id") + def _check_company_id_project_id(self): + for rec in self.sudo(): + if ( + rec.company_id + and rec.project_id.company_id + and rec.company_id != rec.project_id.company_id + ): + raise ValidationError( + self.env._( + "The Company in the Timesheet Sheet and in the Project " + "must be the same." + ) + ) + + def _get_possible_reviewers(self): + self.ensure_one() + res = super()._get_possible_reviewers() + if self.review_policy == "project_manager": + res |= self.project_id.user_id + return res + + def _get_timesheet_sheet_lines_domain(self): + domain = super()._get_timesheet_sheet_lines_domain() + if self.review_policy == "project_manager": + domain += [("project_id", "=", self.project_id.id)] + else: + domain += [("project_id", "!=", False)] + return domain + + @api.onchange("project_id") + def _onchange_project_id(self): + self.add_line_project_id = self.project_id + self._compute_timesheet_ids() + + def _check_can_review(self): + res = super()._check_can_review() + if self.filtered( + lambda sheet: not sheet.can_review + and sheet.review_policy == "project_manager" + ): + raise UserError(self.env._("Only a Project Manager can review the sheet.")) + return res + + def reset_add_line(self): + res = super().reset_add_line() + self.write({"add_line_project_id": self.project_id.id}) + return res + + @api.constrains("review_policy", "project_id") + def _check_review_policy(self): + for rec in self: + if rec.review_policy == "project_manager" and not rec.project_id: + raise UserError( + self.env._( + 'Review policy "By Project Manager" requires Project to be set' + ) + ) diff --git a/hr_timesheet_sheet_policy_project_manager/models/res_company.py b/hr_timesheet_sheet_policy_project_manager/models/res_company.py new file mode 100644 index 0000000000..2324127066 --- /dev/null +++ b/hr_timesheet_sheet_policy_project_manager/models/res_company.py @@ -0,0 +1,12 @@ +# Copyright 2019 Brainbean Apps (https://brainbeanapps.com) +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html). + +from odoo import fields, models + + +class ResCompany(models.Model): + _inherit = "res.company" + + timesheet_sheet_review_policy = fields.Selection( + selection_add=[("project_manager", "By Project Manager")] + ) diff --git a/hr_timesheet_sheet_policy_project_manager/pyproject.toml b/hr_timesheet_sheet_policy_project_manager/pyproject.toml new file mode 100644 index 0000000000..4231d0cccb --- /dev/null +++ b/hr_timesheet_sheet_policy_project_manager/pyproject.toml @@ -0,0 +1,3 @@ +[build-system] +requires = ["whool"] +build-backend = "whool.buildapi" diff --git a/hr_timesheet_sheet_policy_project_manager/readme/CONFIGURE.md b/hr_timesheet_sheet_policy_project_manager/readme/CONFIGURE.md new file mode 100644 index 0000000000..83dedd186e --- /dev/null +++ b/hr_timesheet_sheet_policy_project_manager/readme/CONFIGURE.md @@ -0,0 +1 @@ +Go to Timesheets > Configuration > Timesheet Options > Timesheet Sheet Review Policy and select the option "By Project Manager". \ No newline at end of file diff --git a/hr_timesheet_sheet_policy_project_manager/readme/CONTRIBUTORS.md b/hr_timesheet_sheet_policy_project_manager/readme/CONTRIBUTORS.md new file mode 100644 index 0000000000..e0da29c3d2 --- /dev/null +++ b/hr_timesheet_sheet_policy_project_manager/readme/CONTRIBUTORS.md @@ -0,0 +1,2 @@ +- [CorporateHub](https://corporatehub.eu/) + - Alexey Pelykh \<\> diff --git a/hr_timesheet_sheet_policy_project_manager/readme/DESCRIPTION.md b/hr_timesheet_sheet_policy_project_manager/readme/DESCRIPTION.md new file mode 100644 index 0000000000..0f967236ea --- /dev/null +++ b/hr_timesheet_sheet_policy_project_manager/readme/DESCRIPTION.md @@ -0,0 +1,2 @@ +This module allows setting Department Manager as Reviewer on Timesheet +Sheets. diff --git a/hr_timesheet_sheet_policy_project_manager/readme/USAGE.md b/hr_timesheet_sheet_policy_project_manager/readme/USAGE.md new file mode 100644 index 0000000000..332293256a --- /dev/null +++ b/hr_timesheet_sheet_policy_project_manager/readme/USAGE.md @@ -0,0 +1,3 @@ +- The "Project" field is added to the Timesheet Sheets. +- The records that will be created in the sheets will be filtered by the defined project. +- The possible reviewers will also be the Project Managers of the corresponding project. \ No newline at end of file diff --git a/hr_timesheet_sheet_policy_project_manager/static/description/icon.png b/hr_timesheet_sheet_policy_project_manager/static/description/icon.png new file mode 100644 index 0000000000..3a0328b516 Binary files /dev/null and b/hr_timesheet_sheet_policy_project_manager/static/description/icon.png differ diff --git a/hr_timesheet_sheet_policy_project_manager/static/description/index.html b/hr_timesheet_sheet_policy_project_manager/static/description/index.html new file mode 100644 index 0000000000..cf460aa5df --- /dev/null +++ b/hr_timesheet_sheet_policy_project_manager/static/description/index.html @@ -0,0 +1,450 @@ + + + + + +README.rst + + + +
+ + + +Odoo Community Association + +
+

HR Timesheet Sheet: Project Manager Policy

+ +

Beta License: AGPL-3 OCA/timesheet Translate me on Weblate Try me on Runboat

+

This module allows setting Department Manager as Reviewer on Timesheet +Sheets.

+

Table of contents

+ +
+

Configuration

+

Go to Timesheets > Configuration > Timesheet Options > Timesheet Sheet +Review Policy and select the option “By Project Manager”.

+
+
+

Usage

+
    +
  • The “Project” field is added to the Timesheet Sheets.
    • +
  • The records that will be created in the sheets will be filtered by the +defined project.
    • +
  • The possible reviewers will also be the Project Managers of the +corresponding project.
    • +
+
+
+

Bug Tracker

+

Bugs are tracked on GitHub Issues. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +feedback.

+

Do not contact contributors directly about support or help with technical issues.

+
+
+

Credits

+
+

Authors

+
    +
  • CorporateHub
    • +
+
+
+

Contributors

+ +
+
+

Maintainers

+

This module is maintained by the OCA.

+ +Odoo Community Association + +

OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use.

+

This module is part of the OCA/timesheet project on GitHub.

+

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

+
+
+
+
+ + diff --git a/hr_timesheet_sheet_policy_project_manager/tests/__init__.py b/hr_timesheet_sheet_policy_project_manager/tests/__init__.py new file mode 100644 index 0000000000..6bba9925fa --- /dev/null +++ b/hr_timesheet_sheet_policy_project_manager/tests/__init__.py @@ -0,0 +1,3 @@ +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from . import test_hr_timesheet_sheet_policy_project_manager diff --git a/hr_timesheet_sheet_policy_project_manager/tests/test_hr_timesheet_sheet_policy_project_manager.py b/hr_timesheet_sheet_policy_project_manager/tests/test_hr_timesheet_sheet_policy_project_manager.py new file mode 100644 index 0000000000..11ee910e25 --- /dev/null +++ b/hr_timesheet_sheet_policy_project_manager/tests/test_hr_timesheet_sheet_policy_project_manager.py @@ -0,0 +1,129 @@ +# Copyright 2019 Brainbean Apps (https://brainbeanapps.com) +# Copyright 2025 Tecnativa - Víctor Martínez +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from odoo.exceptions import UserError, ValidationError +from odoo.tests.common import users +from odoo.tools import mute_logger + +from odoo.addons.hr_timesheet_sheet.tests.test_hr_timesheet_sheet import ( + TestHrTimesheetSheetCommon, +) + + +class TestHrTimesheetSheetPolicyProjectManager(TestHrTimesheetSheetCommon): + @classmethod + def setUpClass(cls): + super().setUpClass() + cls.project_manager_user_1 = cls.user_3 + cls.project_manager_user_2 = cls.user_4 + + @mute_logger("odoo.models.unlink") + @users("test_user") + def test_review_policy_capture(self): + self.company.timesheet_sheet_review_policy = "project_manager" + sheet_model = self.sheet_model.with_user(self.env.user) + sheet = sheet_model.create({"project_id": self.project_1.id}) + self.assertEqual(sheet.review_policy, "project_manager") + self.company.timesheet_sheet_review_policy = "hr" + self.assertEqual(sheet.review_policy, "project_manager") + sheet.unlink() + self.assertFalse(sheet.exists()) + + @mute_logger("odoo.models.unlink") + def test_project_manager_review_policy(self): + self.company.timesheet_sheet_review_policy = "project_manager" + timesheet_0 = self.aal_model.with_user(self.user).create( + { + "name": "test", + "project_id": self.project_2.id, + "employee_id": self.employee.id, + } + ) + timesheet_1 = self.aal_model.with_user(self.user).create( + { + "name": "test", + "project_id": self.project_1.id, + "employee_id": self.employee.id, + } + ) + with self.assertRaises(UserError): + self.sheet_model.with_user(self.user).create( + {"company_id": self.employee.company_id.id} + ) + sheet = self.sheet_model.with_user(self.user).create( + { + "company_id": self.employee.company_id.id, + "project_id": self.project_1.id, + } + ) + with self.assertRaises(UserError): + sheet.project_id = False + self.company.timesheet_sheet_review_policy = "hr" + sheet._onchange_project_id() + sheet._onchange_scope() + sheet._onchange_timesheets() + self.assertEqual(len(sheet.timesheet_ids), 1) + self.assertEqual(len(sheet.line_ids), 7) + with self.assertRaises(UserError): + sheet.with_user(self.project_manager_user_2).action_timesheet_done() + with self.assertRaises(UserError): + sheet.with_user(self.project_manager_user_2).action_timesheet_draft() + sheet.action_timesheet_confirm() + self.assertFalse(sheet.with_user(self.user).can_review) + self.assertEqual( + self.sheet_model.with_user(self.user).search_count( + [("can_review", "=", True)] + ), + 0, + ) + with self.assertRaises(UserError): + sheet.with_user(self.user).action_timesheet_done() + sheet.with_user(self.project_manager_user_1).action_timesheet_done() + sheet.with_user(self.project_manager_user_1).action_timesheet_draft() + sheet.unlink() + self.assertFalse(sheet.exists()) + timesheet_0.unlink() + self.assertFalse(timesheet_0.exists()) + timesheet_1.unlink() + self.assertFalse(timesheet_1.exists()) + + @mute_logger("odoo.models.unlink") + @users("test_user") + def test_project_manager_review_policy_project_required(self): + sheet_model = self.sheet_model.with_user(self.env.user) + sheet = sheet_model.new( + { + "date_start": self.sheet_model._default_date_start(), + "date_end": self.sheet_model._default_date_end(), + "review_policy": "project_manager", + "state": "new", + } + ) + values = sheet._convert_to_write(sheet._cache) + with self.assertRaises(UserError): + sheet_model.create(values) + sheet.project_id = self.project_1 + values.update(sheet._convert_to_write(sheet._cache)) + sheet = sheet_model.create(values) + with self.assertRaises(UserError): + sheet.project_id = False + sheet.unlink() + self.assertFalse(sheet.exists()) + + @mute_logger("odoo.models.unlink") + @users("test_user") + def test_project_manager_review_policy_overlapping(self): + self.company.timesheet_sheet_review_policy = "project_manager" + sheet_model = self.sheet_model.with_user(self.env.user) + sheet1 = sheet_model.create({"project_id": self.project_1.id}) + with self.assertRaises(ValidationError): + sheet2 = sheet_model.create({"project_id": self.project_1.id}) + sheet2 = sheet_model.create({"project_id": self.project_2.id}) + with self.assertRaises(ValidationError): + sheet2.write({"project_id": self.project_1.id}) + self.company.timesheet_sheet_review_policy = "hr" + sheet1.unlink() + self.assertFalse(sheet1.exists()) + sheet2.unlink() + self.assertFalse(sheet2.exists()) diff --git a/hr_timesheet_sheet_policy_project_manager/views/hr_timesheet_sheet.xml b/hr_timesheet_sheet_policy_project_manager/views/hr_timesheet_sheet.xml new file mode 100644 index 0000000000..701a345e8f --- /dev/null +++ b/hr_timesheet_sheet_policy_project_manager/views/hr_timesheet_sheet.xml @@ -0,0 +1,67 @@ + + + + + hr_timesheet.sheet.form + hr_timesheet.sheet + + + + + + + review_policy=='project_manager' + + + parent.state!='new' + parent.review_policy=='project_manager' + + + parent.state!='new' + parent.review_policy=='project_manager' + + + + + hr_timesheet.sheet.filter + hr_timesheet.sheet + + + + + + + + + + + diff --git a/test-requirements.txt b/test-requirements.txt new file mode 100644 index 0000000000..2ceaf84957 --- /dev/null +++ b/test-requirements.txt @@ -0,0 +1,2 @@ +odoo-addon-hr_timesheet_sheet @ git+https://github.com/OCA/timesheet.git@refs/pull/841/head#subdirectory=hr_timesheet_sheet +odoo-addon-web_widget_x2many_2d_matrix @ git+https://github.com/OCA/web.git@refs/pull/3310/head#subdirectory=web_widget_x2many_2d_matrix