Skip to content

[19.0][MIG] project_timesheet_holidays_editable#935

Open
cgarcia-solvos wants to merge 5 commits into
OCA:19.0from
solvosci:19.0-mig-project_timesheet_holidays_editable
Open

[19.0][MIG] project_timesheet_holidays_editable#935
cgarcia-solvos wants to merge 5 commits into
OCA:19.0from
solvosci:19.0-mig-project_timesheet_holidays_editable

Conversation

@cgarcia-solvos

@cgarcia-solvos cgarcia-solvos commented May 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Migrate project_timesheet_holidays_editable from 18.0 to 19.0.
The addon restores the editing of timesheets generated from Time Off requests


Context and Rationale:

In Odoo 18, the core project_timesheet_holidays module allowed parameterizing the timesheet generation (project and task) at the Leave Type level (hr.leave.type).
However, in Odoo 19, the core module has undergone a refactor to enforce a multi-company design. The configuration used to generate timesheets has been moved to the Company level (res.company / exposed via res.config.settings).


What changed in this migration

  • Bumped __manifest__.py version to 19.0.1.0.0.
  • Moved Configuration: The timesheet_edit_level setting has been moved from hr.leave.type to res.company and exposed in res.config.settings. It now acts as a global, per-company parameter just like the native timesheet project/task settings.
  • Updated Logic: The account.analytic.line validation now reads the editability setting directly from the employee's company instead of the leave type.
  • Tests Refactored and updated the test to inherit from BaseCommon as indicated in the migration guide.

@OCA-git-bot OCA-git-bot added series:19.0 mod:project_timesheet_holidays_editable Module project_timesheet_holidays_editable labels May 28, 2026
@cgarcia-solvos

Copy link
Copy Markdown
Contributor Author

@WesleyOliveira98 @CristianoMafraJunior could you review? Thanks!!

@cgarcia-solvos cgarcia-solvos mentioned this pull request May 28, 2026
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:project_timesheet_holidays_editable Module project_timesheet_holidays_editable series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants