[19.0][MIG] project_timesheet_holidays_editable#935
Open
cgarcia-solvos wants to merge 5 commits into
Open
Conversation
Re-enables timesheet edition when they're generated from leaves
Contributor
Author
|
@WesleyOliveira98 @CristianoMafraJunior could you review? Thanks!! |
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate
project_timesheet_holidays_editablefrom 18.0 to 19.0.The addon restores the editing of timesheets generated from Time Off requests
Context and Rationale:
In Odoo 18, the core
project_timesheet_holidaysmodule allowed parameterizing the timesheet generation (project and task) at the Leave Type level (hr.leave.type).However, in Odoo 19, the core module has undergone a refactor to enforce a multi-company design. The configuration used to generate timesheets has been moved to the Company level (
res.company/ exposed viares.config.settings).What changed in this migration
__manifest__.pyversion to19.0.1.0.0.timesheet_edit_levelsetting has been moved fromhr.leave.typetores.companyand exposed inres.config.settings. It now acts as a global, per-company parameter just like the native timesheet project/task settings.account.analytic.linevalidation now reads the editability setting directly from the employee's company instead of the leave type.BaseCommonas indicated in the migration guide.