Skip to content

getCV() does not pass Cyclops control settings #672

@egillax

Description

@egillax

fitCyclopsModel() passes a control object to the final Cyclops fit, but the later fold refits in getCV() do not.

This means CV predictions may ignore settings such as threads, seed, tolerance, and maxIterations.

The final trained model should be unaffected. The issue is limited to PLP-generated CV predictions / CV performance summaries for Cyclops logistic models.

Likely fix: pass an optional control argument through createCyclopsModel() to getCV(), and then into the fold-level Cyclops::fitCyclopsModel() call.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions