Skip to content

major ui cleanup - phase 1 #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
evic2132 wants to merge 20 commits into
base: next
Choose a base branch
from

Merge remote-tracking branch 'origin/next' into bugFix/cleanup-next

1fc8b70
Select commit
Loading
Failed to load commit list.
Open

major ui cleanup - phase 1 #672

Merge remote-tracking branch 'origin/next' into bugFix/cleanup-next
1fc8b70
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / detekt succeeded Jun 10, 2025 in 24s

71 new alerts

New alerts in code changed by this pull request

  • 71 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 210 in app/src/main/java/net/opendasharchive/openarchive/db/Space.kt

See this annotation in the file changed.

Code scanning / detekt

Reports mis-indented code Warning

Unexpected indentation (12) (should be 8)

Check warning on line 215 in app/src/main/java/net/opendasharchive/openarchive/db/Space.kt

See this annotation in the file changed.

Code scanning / detekt

Reports mis-indented code Warning

Unexpected indentation (12) (should be 8)

Check warning on line 220 in app/src/main/java/net/opendasharchive/openarchive/db/Space.kt

See this annotation in the file changed.

Code scanning / detekt

Reports mis-indented code Warning

Unexpected indentation (12) (should be 8)

Check warning on line 222 in app/src/main/java/net/opendasharchive/openarchive/db/Space.kt

See this annotation in the file changed.

Code scanning / detekt

Reports mis-indented code Warning

Unexpected indentation (12) (should be 8)

Check warning on line 1 in app/src/main/java/net/opendasharchive/openarchive/features/core/NavArgument.kt

See this annotation in the file changed.

Code scanning / detekt

Detects missing final newlines Warning

File must end with a newline (\n)

Check warning on line 9 in app/src/main/java/net/opendasharchive/openarchive/features/core/NavArgument.kt

See this annotation in the file changed.

Code scanning / detekt

Checks whether files end with a line separator. Warning

The file /home/runner/work/Save-app-android-old/Save-app-android-old/app/src/main/java/net/opendasharchive/openarchive/features/core/NavArgument.kt is not ending with a new line.

Check warning on line 64 in app/src/main/java/net/opendasharchive/openarchive/features/folders/AddFolderScreen.kt

See this annotation in the file changed.

Code scanning / detekt

Library classes should not be public. Warning

Top level function AddFolderScreen should not be public

Check warning on line 1 in app/src/main/java/net/opendasharchive/openarchive/features/internetarchive/presentation/details/InternetArchiveDetailsFragment.kt

See this annotation in the file changed.

Code scanning / detekt

Detects missing final newlines Warning

File must end with a newline (\n)

Check warning on line 51 in app/src/main/java/net/opendasharchive/openarchive/features/internetarchive/presentation/details/InternetArchiveDetailsFragment.kt

See this annotation in the file changed.

Code scanning / detekt

Library classes should not be public. Warning

Class InternetArchiveDetailsFragment should not be public

Check warning on line 16 in app/src/main/java/net/opendasharchive/openarchive/features/internetarchive/presentation/details/InternetArchiveDetailsFragment.kt

See this annotation in the file changed.

Code scanning / detekt

Reports spaces around colons Warning

Missing spacing before ":"

Check warning on line 24 in app/src/main/java/net/opendasharchive/openarchive/features/internetarchive/presentation/details/InternetArchiveDetailsFragment.kt

See this annotation in the file changed.

Code scanning / detekt

Reports methods that have an empty first line. Warning

First line in a method block should not be empty

Check warning on line 36 in app/src/main/java/net/opendasharchive/openarchive/features/internetarchive/presentation/details/InternetArchiveDetailsFragment.kt

See this annotation in the file changed.

Code scanning / detekt

Detects blank lines before rbraces Warning

Unexpected blank line(s) before "}"

Check warning on line 51 in app/src/main/java/net/opendasharchive/openarchive/features/internetarchive/presentation/details/InternetArchiveDetailsFragment.kt

See this annotation in the file changed.

Code scanning / detekt

Checks whether files end with a line separator. Warning

The file /home/runner/work/Save-app-android-old/Save-app-android-old/app/src/main/java/net/opendasharchive/openarchive/features/internetarchive/presentation/details/InternetArchiveDetailsFragment.kt is not ending with a new line.

Check warning on line 35 in app/src/main/java/net/opendasharchive/openarchive/features/internetarchive/presentation/details/InternetArchiveDetailsScreen.kt

See this annotation in the file changed.

Code scanning / detekt

Detects unused imports Warning

Unused import

Check warning on line 42 in app/src/main/java/net/opendasharchive/openarchive/features/internetarchive/presentation/details/InternetArchiveDetailsScreen.kt

See this annotation in the file changed.

Code scanning / detekt

Function names should follow the naming convention set in the configuration. Warning

Function names should match the pattern: [a-z][a-zA-Z0-9]*

Check warning on line 44 in app/src/main/java/net/opendasharchive/openarchive/features/internetarchive/presentation/details/InternetArchiveDetailsScreen.kt

See this annotation in the file changed.

Code scanning / detekt

Lambda parameters in a @Composable that are referenced directly inside of restarting effects can cause issues or unpredictable behavior. If restarting the effect is ok, you can add the reference to this parameter as a key in that effect, so when the parameter changes, a new effect is created. However, if the effect is not to be restarted, you will need to use `rememberUpdatedState` on the parameter and use its result in the effect. See https://mrmans0n.github.io/compose-rules/rules/#be-mindful-of-the-arguments-you-use-inside-of-a-restarting-effect for more information. Warning

Lambda parameters in a @Composable that are referenced directly inside of restarting effects can cause issues or unpredictable behavior.
If restarting the effect is ok, you can add the reference to this parameter as a key in that effect, so when the parameter changes, a new effect is created.
However, if the effect is not to be restarted, you will need to use rememberUpdatedState on the parameter and use its result in the effect.
See https://mrmans0n.github.io/compose-rules/rules/#be-mindful-of-the-arguments-you-use-inside-of-a-restarting-effect for more information.

Check warning on line 81 in app/src/main/java/net/opendasharchive/openarchive/features/internetarchive/presentation/details/InternetArchiveDetailsScreen.kt

See this annotation in the file changed.

Code scanning / detekt

Checks if comments have the right spacing Warning

Missing space after //

Check warning on line 1 in app/src/main/java/net/opendasharchive/openarchive/features/internetarchive/presentation/login/InternetArchiveLoginFragment.kt

See this annotation in the file changed.

Code scanning / detekt

Detects missing final newlines Warning

File must end with a newline (\n)

Check warning on line 53 in app/src/main/java/net/opendasharchive/openarchive/features/internetarchive/presentation/login/InternetArchiveLoginFragment.kt

See this annotation in the file changed.

Code scanning / detekt

Library classes should not be public. Warning

Class InternetArchiveLoginFragment should not be public

Check warning on line 16 in app/src/main/java/net/opendasharchive/openarchive/features/internetarchive/presentation/login/InternetArchiveLoginFragment.kt

See this annotation in the file changed.

Code scanning / detekt

Reports spaces around colons Warning

Missing spacing before ":"

Check warning on line 19 in app/src/main/java/net/opendasharchive/openarchive/features/internetarchive/presentation/login/InternetArchiveLoginFragment.kt

See this annotation in the file changed.

Code scanning / detekt

Reports consecutive blank lines Warning

Needless blank line(s)

Check warning on line 25 in app/src/main/java/net/opendasharchive/openarchive/features/internetarchive/presentation/login/InternetArchiveLoginFragment.kt

See this annotation in the file changed.

Code scanning / detekt

Reports methods that have an empty first line. Warning

First line in a method block should not be empty

Check warning on line 38 in app/src/main/java/net/opendasharchive/openarchive/features/internetarchive/presentation/login/InternetArchiveLoginFragment.kt

See this annotation in the file changed.

Code scanning / detekt

Reports lines with exceeded length Warning

Exceeded max line length (120)

Check warning on line 53 in app/src/main/java/net/opendasharchive/openarchive/features/internetarchive/presentation/login/InternetArchiveLoginFragment.kt

See this annotation in the file changed.

Code scanning / detekt

Checks whether files end with a line separator. Warning

The file /home/runner/work/Save-app-android-old/Save-app-android-old/app/src/main/java/net/opendasharchive/openarchive/features/internetarchive/presentation/login/InternetArchiveLoginFragment.kt is not ending with a new line.

Check warning on line 3 in app/src/main/java/net/opendasharchive/openarchive/features/internetarchive/presentation/login/InternetArchiveLoginState.kt

See this annotation in the file changed.

Code scanning / detekt

Detects unused imports Warning

Unused import