MSVC2019 Port & Small fixes#24
Merged
Merged
Conversation
…en playing a sound is not completed, but we are destroying it
Xottab-DUTY
requested changes
May 7, 2026
…tter because they're reserved by cpp standard
Xottab-DUTY
reviewed
Jun 2, 2026
Xottab-DUTY
approved these changes
Jun 2, 2026
Xottab-DUTY
left a comment
Xottab-DUTY
left a comment
Member
There was a problem hiding this comment.
@tyabus I'm ready to merge this PR, but it's marked as a draft currently. Is it ready for merge?
Contributor
Author
|
If there are no other required changes then yes, it is. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xrGame:
Allow players to change hud_draw,fov,hud_fov on non-debug builds
Replace debug_make_final with C++11 final specifier
Remove uialloc, Replace DEF_UILIST with inplace type alias
CScriptSound: Log an script lua error instead of THROW3ing when playing a sound is not completed, but we are destroying it
CAbstractGraph::save: Fix hides previous local declaration warning
xrCore:
Add guard to prevent _CRT_SECURE_NO_DEPRECATE redefinition
xrRender:
Abort occlusion call when the ID is invalid not only on release builds
VS Projects:
Upgrade VS Projects to MSVC2019, Fix Mixed configuration
MSVC 2019 and greater build fixes