Skip to content

refactor: Add type safety to graphQL queries and query improvements #79

Description

@UrbanWill

Issue:

Existing graphQl queries are not typed. Untyped queries make it easier for bugs to be introduced, diminishes DX and make it hard to refactor existing queries.

How to add type safety with React-query and graphQl

https://the-guild.dev/graphql/codegen/docs/guides/react-query

What's next

After adding types, we can confidently refactor existing queries that may be slowing down Signet:

  • AddressesByOrgId should only be called when needed and should be paginated. The current limit of 1000 is too high. Consider the effects this may have on useKnownAddresses. Refactor: address input #83
  • TxMetadata should be queried on demand when needed. Also, the 300 limit may be too large, and at the same time too small to cover the entire multisig team's transaction list. Perf: tx-Metadata refactor #87
  • GetTransactions: We are fetching too much data. Consider implementing pagination.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions