fix(api): prevent false positive truncation warning when query result count equals limit - #12
Open
trexfr-ops wants to merge 1 commit into
Conversation
… count equals limit
4 tasks
|
😅 Unfortunately there are no rewards left to claim in this issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1
This PR resolves the false positive truncation warning in the Prometheus query execution path where queries returning exactly
Nitems against a limit ofNincorrectly appended a truncation warning.Key Changes
web/api/v1/api.goto requestlimit + 1elements when evaluating limited queries.query processing limit reachedwarning are now only triggered whenlen(fetched) > limit. Whenlen(fetched) <= limit, all results are returned with zero warnings.web/api/v1/api_test.gocovering under-limit, exact-limit boundary, over-limit truncation, and range queries (all 5 tests passing).Bounty Claim & Payout Addresses
/claim #1
LPnftYop8yhRNQZstysT3vuJf3XkpQWKTC0x32BB3df5B74a594956a0f33Bc353511Fa759FCa48Xo39uq9LoaM2rQEkgaaSfuThqHZTd18yGdJSXffkLwMbc1qpyu6866qcgt26sqw4dn2mlmp8d0yc657fuedkvDDMU6D9TCE3BhqqYyy7MUZQD7JhfL39FpE