From d7c955aa14f73488254446856cf287601017d2b6 Mon Sep 17 00:00:00 2001 From: lwin Date: Tue, 28 Apr 2026 01:20:12 +0800 Subject: [PATCH 1/3] feat: added wsEmabedDappClientId to auth --- package-lock.json | 21 ++++++++++++++++++++- src/core/auth.ts | 1 + src/utils/interfaces.ts | 12 ++++++++++++ 3 files changed, 33 insertions(+), 1 deletion(-) diff --git a/package-lock.json b/package-lock.json index 5749cefa..33c33fcd 100644 --- a/package-lock.json +++ b/package-lock.json @@ -95,6 +95,7 @@ "integrity": "sha512-CGOfOJqWjg2qW/Mb6zNsDm+u5vFQ8DxXfbM09z69p5Z6+mE1ikP2jUXw+j42Pf1XTYED2Rni5f95npYeuwMDQA==", "dev": true, "license": "MIT", + "peer": true, "dependencies": { "@babel/code-frame": "^7.29.0", "@babel/generator": "^7.29.0", @@ -1675,6 +1676,7 @@ "resolved": "https://registry.npmjs.org/@babel/runtime/-/runtime-7.29.2.tgz", "integrity": "sha512-JiDShH45zKHWyGe4ZNVRrCjBz8Nh9TMmZG1kh4QTK8hCBTWBi8Da+i7s1fJw7/lYpM4ccepSNfqzZ/QvABBi5g==", "license": "MIT", + "peer": true, "engines": { "node": ">=6.9.0" } @@ -3138,6 +3140,7 @@ "integrity": "sha512-DhGl4xMVFGVIyMwswXeyzdL4uXD5OGILGX5N8Y+f6W7LhC1Ze2poSNrkF/fedpVDHEEZ+PHFW0vL14I+mm8K3Q==", "dev": true, "license": "MIT", + "peer": true, "dependencies": { "@octokit/auth-token": "^6.0.0", "@octokit/graphql": "^9.0.3", @@ -4664,6 +4667,7 @@ "integrity": "sha512-DpzbrH7wIcBaJibpKo9nnSQL0MTRdnWttGyE5haGwK86xgMOkFLp7vEyfQPGLOJh5wNYiJ3V9PmUMDhV9u8kkQ==", "dev": true, "license": "MIT", + "peer": true, "dependencies": { "undici-types": "~7.18.0" } @@ -4744,6 +4748,7 @@ "integrity": "sha512-klQbnPAAiGYFyI02+znpBRLyjL4/BrBd0nyWkdC0s/6xFLkXYQ8OoRrSkqacS1ddVxf/LDyODIKbQ5TgKAf/Fg==", "dev": true, "license": "MIT", + "peer": true, "dependencies": { "@typescript-eslint/scope-manager": "8.56.1", "@typescript-eslint/types": "8.56.1", @@ -5404,6 +5409,7 @@ "integrity": "sha512-UVJyE9MttOsBQIDKw1skb9nAwQuR5wuGD3+82K6JgJlm/Y+KI92oNsMNGZCYdDsVtRHSak0pcV5Dno5+4jh9sw==", "dev": true, "license": "MIT", + "peer": true, "bin": { "acorn": "bin/acorn" }, @@ -5941,6 +5947,7 @@ } ], "license": "MIT", + "peer": true, "dependencies": { "baseline-browser-mapping": "^2.9.0", "caniuse-lite": "^1.0.30001759", @@ -7120,6 +7127,7 @@ "integrity": "sha512-VmQ+sifHUbI/IcSopBCF/HO3YiHQx/AVd3UVyYL6weuwW+HvON9VYn5l6Zl1WZzPWXPNZrSQpxwkkZ/VuvJZzg==", "dev": true, "license": "MIT", + "peer": true, "dependencies": { "@eslint-community/eslint-utils": "^4.8.0", "@eslint-community/regexpp": "^4.12.1", @@ -7180,6 +7188,7 @@ "integrity": "sha512-82GZUjRS0p/jganf6q1rEO25VSoHH0hKPCTrgillPjdI/3bgBhAE1QzHrHTizjpRvy6pGAvKjDJtk2pF9NDq8w==", "dev": true, "license": "MIT", + "peer": true, "bin": { "eslint-config-prettier": "bin/cli.js" }, @@ -7306,6 +7315,7 @@ "integrity": "sha512-whOE1HFo/qJDyX4SnXzP4N6zOWn79WhnCUY/iDR0mPfQZO8wcYE4JClzI2oZrhBnnMUCBCHZhO6VQyoBU95mZA==", "dev": true, "license": "MIT", + "peer": true, "dependencies": { "@rtsao/scc": "^1.1.0", "array-includes": "^3.1.9", @@ -10109,6 +10119,7 @@ "integrity": "sha512-E3ZJh4J3S9KfwdjZhe2afj6R9lGIN5Pher1pF39UGrXRqq/VDaGVIGN13BjHd2u8B61hArAGOnso7nBOouW3TQ==", "dev": true, "license": "MIT", + "peer": true, "dependencies": { "@babel/parser": "^7.29.0", "@babel/types": "^7.29.0", @@ -11076,6 +11087,7 @@ "integrity": "sha512-UOnG6LftzbdaHZcKoPFtOcCKztrQ57WkHDeRD9t/PTQtmT0NHSeWWepj6pS0z/N7+08BHFDQVUrfmfMRcZwbMg==", "dev": true, "license": "MIT", + "peer": true, "bin": { "prettier": "bin/prettier.cjs" }, @@ -11606,6 +11618,7 @@ "integrity": "sha512-2oMpl67a3zCH9H79LeMcbDhXW/UmWG/y2zuqnF2jQq5uq9TbM9TVyXvA4+t+ne2IIkBdrLpAaRQAvo7YI/Yyeg==", "dev": true, "license": "MIT", + "peer": true, "dependencies": { "@types/estree": "1.0.8" }, @@ -12617,7 +12630,8 @@ "resolved": "https://registry.npmjs.org/tslib/-/tslib-2.8.1.tgz", "integrity": "sha512-oJFu94HQb+KVduSUQL7wnpmqnfmLsOA/nAh6b6EH0wCEoK0/mPeXU6c3wKDV83MkOuHPRHtSXKKU99IBazS/2w==", "devOptional": true, - "license": "0BSD" + "license": "0BSD", + "peer": true }, "node_modules/tsx": { "version": "4.21.0", @@ -12625,6 +12639,7 @@ "integrity": "sha512-5C1sg4USs1lfG0GFb2RLXsdpXqBSEhAaA/0kPL01wxzpMqLILNxIxIOKiILz+cdg/pLnOUxFYOR5yhHU666wbw==", "dev": true, "license": "MIT", + "peer": true, "dependencies": { "esbuild": "~0.27.0", "get-tsconfig": "^4.7.5" @@ -12758,6 +12773,7 @@ "integrity": "sha512-jl1vZzPDinLr9eUt3J/t7V6FgNEw9QjvBPdysz9KfQDD41fQrC2Y4vKQdiaUpFT4bXlb1RHhLpp8wtm6M5TgSw==", "dev": true, "license": "Apache-2.0", + "peer": true, "bin": { "tsc": "bin/tsc", "tsserver": "bin/tsserver" @@ -12884,6 +12900,7 @@ "dev": true, "hasInstallScript": true, "license": "MIT", + "peer": true, "dependencies": { "napi-postinstall": "^0.3.0" }, @@ -13007,6 +13024,7 @@ "integrity": "sha512-1gFhNi+bHhRE/qKZOJXACm6tX4bA3Isy9KuKF15AgSRuRazNBOJfdDemPBU16/mpMxApDPrWvZ08DcLPEoRnuA==", "dev": true, "license": "MIT", + "peer": true, "dependencies": { "lightningcss": "^1.32.0", "picomatch": "^4.0.3", @@ -13085,6 +13103,7 @@ "integrity": "sha512-yF+o4POL41rpAzj5KVILUxm1GCjKnELvaqmU9TLLUbMfDzuN0UpUR9uaDs+mCtjPe+uYPksXDRLQGGPvj1cTmA==", "dev": true, "license": "MIT", + "peer": true, "dependencies": { "@vitest/expect": "4.1.1", "@vitest/mocker": "4.1.1", diff --git a/src/core/auth.ts b/src/core/auth.ts index 23485f42..e231a28a 100644 --- a/src/core/auth.ts +++ b/src/core/auth.ts @@ -540,6 +540,7 @@ export class Auth { sessionNamespace: this.options.sessionNamespace, storageServerUrl: this.options.storageServerUrl, loginSource: dataObject.params.loginSource, + wsEmbedDappClientId: dataObject.options.wsEmbedDappClientId, }; if (this.options.uxMode === UX_MODE.REDIRECT) { diff --git a/src/utils/interfaces.ts b/src/utils/interfaces.ts index d0b2b3c9..889fe11d 100644 --- a/src/utils/interfaces.ts +++ b/src/utils/interfaces.ts @@ -548,6 +548,12 @@ export type AuthOptions = { * @defaultValue true */ includeUserDataInToken?: boolean; + + /** + * The client id of the dapp that initiates the login flow in **EMBED** mode. + * @defaultValue undefined + */ + wsEmbedDappClientId?: string; }; export interface BaseLoginParams { @@ -564,6 +570,12 @@ export interface BaseLoginParams { * Optional login source to be used for analytics purposes. */ loginSource?: string; + + /** + * The client id of the dapp that initiates the login flow in **EMBED** mode. + * @defaultValue undefined + */ + wsEmbedDappClientId?: string; } export interface AuthRequestPayload { From a389621d0d489897e7fcad253babe62dec09426e Mon Sep 17 00:00:00 2001 From: lwin Date: Tue, 28 Apr 2026 02:08:06 +0800 Subject: [PATCH 2/3] fix: removed 'wsEmbedDappClientID' from login base params --- src/core/auth.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/core/auth.ts b/src/core/auth.ts index e231a28a..23485f42 100644 --- a/src/core/auth.ts +++ b/src/core/auth.ts @@ -540,7 +540,6 @@ export class Auth { sessionNamespace: this.options.sessionNamespace, storageServerUrl: this.options.storageServerUrl, loginSource: dataObject.params.loginSource, - wsEmbedDappClientId: dataObject.options.wsEmbedDappClientId, }; if (this.options.uxMode === UX_MODE.REDIRECT) { From 8b5beab1f395d0f5feba918b8f357f11a9b95068 Mon Sep 17 00:00:00 2001 From: lwin Date: Tue, 28 Apr 2026 12:02:20 +0800 Subject: [PATCH 3/3] chore: revert BaseLoginParams interface --- src/utils/interfaces.ts | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/utils/interfaces.ts b/src/utils/interfaces.ts index 889fe11d..7b757bf1 100644 --- a/src/utils/interfaces.ts +++ b/src/utils/interfaces.ts @@ -570,12 +570,6 @@ export interface BaseLoginParams { * Optional login source to be used for analytics purposes. */ loginSource?: string; - - /** - * The client id of the dapp that initiates the login flow in **EMBED** mode. - * @defaultValue undefined - */ - wsEmbedDappClientId?: string; } export interface AuthRequestPayload {