From c3e96879e41bcdb88703ef0fdb5d29db19bdfd1b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A9ter=20G=C3=B6m=C3=B6ri?= Date: Fri, 26 Nov 2021 12:09:00 +0100 Subject: [PATCH] Improve error_info() type `erlfmt_scan` returns `erl_anno:location()` in errors however `erlfmt_parse` mostly returns full `erlfmt_scan:anno()` maps. The errors from the parser also surface in the return value of `erlfmt:read_nodes[_string]` --- src/erlfmt.erl | 4 +++- src/erlfmt_parse.yrl | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/erlfmt.erl b/src/erlfmt.erl index 21465c5a..a5f769aa 100644 --- a/src/erlfmt.erl +++ b/src/erlfmt.erl @@ -34,7 +34,9 @@ -export_type([error_info/0, config/0, pragma/0]). --type error_info() :: {file:name_all(), erl_anno:location(), module(), Reason :: any()}. +-type error_info() :: { + file:name_all(), erl_anno:location() | erlfmt_scan:anno(), module(), Reason :: any() +}. -type pragma() :: require | insert | delete | ignore. -type config() :: [{pragma, pragma()} | {print_width, pos_integer()} | verbose]. diff --git a/src/erlfmt_parse.yrl b/src/erlfmt_parse.yrl index fe8d58c5..6c1da622 100644 --- a/src/erlfmt_parse.yrl +++ b/src/erlfmt_parse.yrl @@ -994,7 +994,7 @@ Erlang code. %% XXX. To be refined. -type error_description() :: term(). --type error_info() :: {erl_anno:line(), module(), error_description()}. +-type error_info() :: {erl_anno:location() | erlfmt_scan:anno(), module(), error_description()}. -type token() :: erlfmt_scan:token(). %% mkop(Op, Arg) -> {op,Anno,Op,Arg}.