test: Add more Sponsor tests by mvadari · Pull Request #7783 · XRPLF/rippled

mvadari · 2026-07-09T23:33:46Z

High Level Overview of Change

This PR adds more tests for Sponsor-related code.

No change to source code, just tests.

Context of Change

Better code testing

API Impact

N/A

codecov · 2026-07-10T00:04:16Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.8%. Comparing base (a24e543) to head (c27ae3c).

Additional details and impacted files

@@           Coverage Diff           @@
##           develop   #7783   +/-   ##
=======================================
  Coverage     82.8%   82.8%           
=======================================
  Files         1036    1036           
  Lines        80107   80110    +3     
  Branches      8932    8931    -1     
=======================================
+ Hits         66300   66315   +15     
+ Misses       13798   13786   -12     
  Partials         9       9

see 7 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions · 2026-07-15T14:41:45Z

This PR has conflicts, please resolve them in order for the PR to be reviewed.

github-actions · 2026-07-15T14:43:31Z

All conflicts have been resolved. Assigned reviewers can now start or resume their review.

xrplf-ai-reviewer

No issues.

Review by Claude Sonnet 4.6 · Prompt: V15

oleks-rip · 2026-07-21T18:48:36Z

+            BEAST_EXPECT(a.count() == b.count());
+            BEAST_EXPECT(a < b);
+            BEAST_EXPECT(std::max(a, b) == b);
+        }


sponsored == maxU32 tests missed

oleks-rip · 2026-07-21T18:49:28Z

+
+        auto const a = makeCounts(3, 1, 2);
+        auto const& self = a;
+        BEAST_EXPECT(a == self);                 // self-compare


oleks-rip · 2026-07-21T18:51:56Z

+                sb2.adjustOwnerCountHook(alice, OwnerCounts(), counts);
+
+                // The parent has no entry for alice yet
+                BEAST_EXPECT(sb.ownerCountHook(alice, OwnerCounts()) == OwnerCounts());


aslo sb2 should be tested here

oleks-rip · 2026-07-21T18:53:46Z

+            sb.adjustOwnerCountHook(bob, OwnerCounts(), higher);
+            {
+                PaymentSandbox sb2(&sb);
+                sb2.adjustOwnerCountHook(bob, OwnerCounts(), lower);


test sb2 here too

oleks-rip · 2026-07-21T19:06:45Z

+        // fields (Sequence, Fee, ...) must be fixed before the sponsor
+        // signs; SponsorSignature and Signers are not signing fields, so
+        // later sign_for calls don't invalidate the sponsor's signature.
+        auto setupTx = [&]() {


Please create accountSet helper, like fset(), and use it more standard way, like
env(accountSet(..), Fee(..), MSIg(...))

oleks-rip · 2026-07-21T19:08:08Z

                resp.toStyledString());
        }
+        {
+            // Signed SponsorSignature (non-empty TxnSignature)


same here - why to use direct json editing, when we have a lot of helpers?

oleks-rip · 2026-07-21T19:09:42Z

+        };
+
+        json::Value tx;
+        tx[jss::Account] = alice.human();


Same here - please use UT helpers (Fee(..), SIg(..) Sponsor...)

oleks-rip · 2026-07-21T19:42:12Z

+
+            // Sponsorship with a reserve budget where prefunded (unsigned) use
+            // of the reserve budget requires a sponsor signature.
+            env(sponsor::set_reserve(sponsor, tfSponsorshipSetRequireSignForReserve, 10),


Named not according to standard, should be setReserve

oleks-rip · 2026-07-21T19:45:48Z

+            // (lsfSponsorshipRequireSignForFee), and a co-signed transaction
+            // still draws the fee from the prefunded FeeAmount because
+            // getFeePayer prefers the Sponsorship object when it exists.
+            env(sponsor::set_fee(sponsor, tfSponsorshipSetRequireSignForFee, XRP(10)),


Same - bad name, should be setFee

oleks-rip · 2026-07-21T19:52:44Z

+        // it before the Oracle-specific preflight checks run.
+        {
+            json::Value oracleSet;
+            oracleSet[jss::TransactionType] = jss::OracleSet;


Use Oracle helpers, not direct json editing

oleks-rip · 2026-07-21T19:58:22Z

        checkMetrics(*this, env, 0, 6, 5, 3);
    }

+    void


please add tests for N transactions with the same sponsor and where N-2-ish transaction's fee exhaust sponsor balance

oleks-rip · 2026-07-21T20:31:24Z

+                Ter(temBAD_REGKEY));
+            env.close();
+        }
+    }


Missed batch tests which exhaust sponsor / sponsorship balance through fee and reserve (6 txs and sponsor balance depleted on 3d or 4th)

oleks-rip · 2026-07-21T20:35:01Z

+
+        auto tx = noop(alice);
+        tx[sfSponsor.jsonName] = sponsor.human();
+        tx[sfSponsorFlags.jsonName] = static_cast<std::uint32_t>(spfSponsorFee);


sponsor::As

oleks-rip · 2026-07-21T20:43:54Z

+    }
+
+    void
+    testFeeOnlySponsorshipObjectRouting()


maybe put it next to testCosignedTransferConsumesPrefundedBudget

oleks-rip · 2026-07-22T18:28:32Z

+        BEAST_EXPECT(env.balance(alice) == target);
+        BEAST_EXPECT(env.balance(bob) == target);
+
+        // Control: for the unsponsored account, xrpLiquid = balance - base


Please call xrplLiquid directly here
also call accountReserve and checkReserve here or in similar test

oleks-rip · 2026-07-22T18:41:29Z

+    }
+
+    void
+    testThirdPartyEscrowCancelRefundsSponsor()


missed similar test where expired sponsored credentials were deleted indirectly.

oleks-rip · 2026-07-22T18:46:32Z

+        MPTTester mptt(env, alice, {.fund = false});
+        mptt.create({.flags = tfMPTCanLock});
+        json::Value jvSet;
+        jvSet[sfTransactionType.jsonName] = jss::MPTokenIssuanceSet;


why not use MPTSet structure for creating MPTokenIssuanceSet with MPTTester

mvadari added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Jul 9, 2026

mvadari force-pushed the mvadari/sponsor/ai-tests branch from 5dbe37d to 9c9b66d Compare July 9, 2026 23:34

mvadari changed the title ~~amendment-gate new code~~ add lots of tests Jul 9, 2026

mvadari changed the base branch from xrplf/sponsor to develop July 15, 2026 14:40

mvadari changed the title ~~add lots of tests~~ test: Add more Sponsor tests Jul 15, 2026

github-actions Bot added the PR: has conflicts label Jul 15, 2026

add a boatload of tests (AI)

f234682

mvadari force-pushed the mvadari/sponsor/ai-tests branch from 9c9b66d to f234682 Compare July 15, 2026 14:43

Merge branch 'develop' into mvadari/sponsor/ai-tests

a39dadc

github-actions Bot removed the PR: has conflicts label Jul 15, 2026

mvadari added 2 commits July 15, 2026 12:14

fix test

7d213f2

fix clang-tidy issues

c27ae3c

mvadari marked this pull request as ready for review July 15, 2026 18:20

mvadari removed the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Jul 15, 2026

mvadari requested review from oleks-rip and yinyiqian1 July 15, 2026 18:20

xrplf-ai-reviewer Bot approved these changes Jul 15, 2026

View reviewed changes

oleks-rip reviewed Jul 21, 2026

View reviewed changes

oleks-rip reviewed Jul 22, 2026

View reviewed changes

Uh oh!

Conversation

mvadari commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

High Level Overview of Change

Context of Change

API Impact

Uh oh!

codecov Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Jul 15, 2026

Uh oh!

github-actions Bot commented Jul 15, 2026

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mvadari commented Jul 9, 2026 •

edited

Loading

codecov Bot commented Jul 10, 2026 •

edited

Loading