Skip to content

Merge branch 'main' into fix/llm-context-preflight

d2d464c
Select commit
Loading
Failed to load commit list.
Merged

fix(llm): preflight compact oversized requests #284

Merge branch 'main' into fix/llm-context-preflight
d2d464c
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Apr 15, 2026 in 56s

Annotations

Check warning on line 6 in src/main/java/me/golemcore/bot/domain/system/toolloop/ContextCompactionCoordinator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed.

See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ2OACquDQWxOyURfzST&open=AZ2OACquDQWxOyURfzST&pullRequest=284

Check warning on line 6 in src/main/java/me/golemcore/bot/domain/system/toolloop/CompactionFinishedPayloads.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed.

See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ2OACqkDQWxOyURfzSS&open=AZ2OACqkDQWxOyURfzSS&pullRequest=284

Check warning on line 139 in src/test/java/me/golemcore/bot/domain/system/toolloop/LlmRequestPreflightPhaseTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertNotEquals instead.

See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ2Kib2g56xqTh8S3-FC&open=AZ2Kib2g56xqTh8S3-FC&pullRequest=284

Check warning on line 107 in src/test/java/me/golemcore/bot/domain/system/toolloop/LlmRequestPreflightPhaseTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertEquals instead.

See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ2Kib2g56xqTh8S3-FB&open=AZ2Kib2g56xqTh8S3-FB&pullRequest=284

Check warning on line 317 in src/test/java/me/golemcore/bot/domain/system/toolloop/DefaultToolLoopSystemStopConditionTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertNotEquals instead.

See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ2OACwiDQWxOyURfzSd&open=AZ2OACwiDQWxOyURfzSd&pullRequest=284

Check failure on line 247 in src/test/java/me/golemcore/bot/domain/service/CompactionPayloadMapperTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case.

See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ2OACsjDQWxOyURfzSW&open=AZ2OACsjDQWxOyURfzSW&pullRequest=284

Check warning on line 57 in src/test/java/me/golemcore/bot/domain/system/toolloop/DefaultToolLoopSystemToolFailureRecoveryTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertNotEquals instead.

See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ2OACtqDQWxOyURfzSX&open=AZ2OACtqDQWxOyURfzSX&pullRequest=284

Check warning on line 59 in src/main/java/me/golemcore/bot/domain/service/ContextCompactionPolicy.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "Math.clamp" instead of "Math.min" or "Math.max".

See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ2OACphDQWxOyURfzSQ&open=AZ2OACphDQWxOyURfzSQ&pullRequest=284

Check warning on line 59 in src/main/java/me/golemcore/bot/domain/service/ContextCompactionPolicy.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "Math.clamp" instead of "Math.min" or "Math.max".

See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ2OACphDQWxOyURfzSR&open=AZ2OACphDQWxOyURfzSR&pullRequest=284

Check warning on line 26 in src/test/java/me/golemcore/bot/domain/system/toolloop/DefaultToolLoopSystemModelAndEdgeCaseTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace these 3 tests with a single Parameterized one.

See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ2OACupDQWxOyURfzSa&open=AZ2OACupDQWxOyURfzSa&pullRequest=284

Check warning on line 254 in src/test/java/me/golemcore/bot/domain/system/toolloop/DefaultToolLoopSystemStopConditionTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertEquals instead.

See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ2OACwiDQWxOyURfzSc&open=AZ2OACwiDQWxOyURfzSc&pullRequest=284

Check warning on line 81 in src/main/java/me/golemcore/bot/domain/system/toolloop/ContextCompactionCoordinator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "Math.clamp" instead of "Math.min" or "Math.max".

See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ2OACquDQWxOyURfzSU&open=AZ2OACquDQWxOyURfzSU&pullRequest=284

Check warning on line 72 in src/test/java/me/golemcore/bot/domain/system/toolloop/DefaultToolLoopSystemToolExecutionTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly.

See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ2OACt0DQWxOyURfzSY&open=AZ2OACt0DQWxOyURfzSY&pullRequest=284

Check warning on line 6 in src/main/java/me/golemcore/bot/domain/system/toolloop/LlmRequestPreflightPhase.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed.

See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ2KcN8JWym3B0O6-__a&open=AZ2KcN8JWym3B0O6-__a&pullRequest=284

Check warning on line 556 in src/test/java/me/golemcore/bot/domain/service/CompactionOrchestrationServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly.

See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ2OpkhuGiS5llmBEfny&open=AZ2OpkhuGiS5llmBEfny&pullRequest=284

Check warning on line 57 in src/main/java/me/golemcore/bot/domain/service/ContextCompactionPolicy.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "Math.clamp" instead of "Math.min" or "Math.max".

See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ2OACphDQWxOyURfzSP&open=AZ2OACphDQWxOyURfzSP&pullRequest=284

Check warning on line 313 in src/main/java/me/golemcore/bot/domain/service/ContextTokenEstimator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one.

See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ2OpkSPGiS5llmBEfnw&open=AZ2OpkSPGiS5llmBEfnw&pullRequest=284

Check warning on line 315 in src/main/java/me/golemcore/bot/domain/service/ContextTokenEstimator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code in order to not assign to this loop counter from within the loop body.

See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ2OACbmDQWxOyURfzSO&open=AZ2OACbmDQWxOyURfzSO&pullRequest=284

Check warning on line 6 in src/main/java/me/golemcore/bot/domain/service/ContextTokenEstimator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed.

See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ2KcNz4Wym3B0O6-__Z&open=AZ2KcNz4Wym3B0O6-__Z&pullRequest=284

Check warning on line 239 in src/main/java/me/golemcore/bot/domain/service/ContextTokenEstimator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "e" with an unnamed pattern.

See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ2OpkSPGiS5llmBEfnx&open=AZ2OpkSPGiS5llmBEfnx&pullRequest=284

Check warning on line 518 in src/main/java/me/golemcore/bot/adapter/outbound/llm/Langchain4jAdapter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one.

See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ2OACsGDQWxOyURfzSV&open=AZ2OACsGDQWxOyURfzSV&pullRequest=284

Check warning on line 66 in src/test/java/me/golemcore/bot/domain/system/toolloop/DefaultToolLoopSystemTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception.

See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ2OACwVDQWxOyURfzSb&open=AZ2OACwVDQWxOyURfzSb&pullRequest=284

Check warning on line 106 in src/test/java/me/golemcore/bot/domain/system/toolloop/DefaultToolLoopSystemCompactionTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertEquals instead.

See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ2OACufDQWxOyURfzSZ&open=AZ2OACufDQWxOyURfzSZ&pullRequest=284