Skip to content

Use self convention in transformer.py #244

@thewouter

Description

@thewouter

Description of this issues

In transformer.py the first parameter of some methods is cls. In python cls is by convention reserved for @classmethods. Using it for normal methods can be confusing to the reader.

Suggested solution

  • cls parameters to self parameters whenever the method is not annotated as @classmethod.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Not ready to pick up yetNeeds to be reviewed by the maintainers. Should not be picked up yet.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions