Fix typos, grammar, and comment inconsistencies in parquet.thrift#573
Merged
Conversation
etseidl
reviewed
Jun 2, 2026
etseidl
left a comment
etseidl
left a comment
Contributor
There was a problem hiding this comment.
Thanks for taking this on. Just a few minor nits.
etseidl
approved these changes
Jun 3, 2026
etseidl
left a comment
etseidl
left a comment
Contributor
There was a problem hiding this comment.
Thanks. Just a few more "edges" to clean up.
Fokko
approved these changes
Jun 5, 2026
- Fix typos: "to be be", "documention", "not necessary"
- Remove off-by-one in DataPageHeaderV2 is_compressed comment
- Fix article agreement ("a element" -> "an element", "a OffsetIndex" -> "an OffsetIndex")
- Disambiguate compressed_page_size comment in PageLocation
- Fix "edges interpolation" -> "edge interpolation" in Geospatial comments
- Capitalize proper nouns: Hive, Pig; normalize GZIP casing
- Add terminal periods for consistency
- Clarify BIT_PACKED is superseded by RLE (cross-reference Encodings.md)
- Missing space before parenthesis in frameworks list
Thrift validation passes after these edits.
… standardize DEPRECATED
iemejia
force-pushed
the
fix/thrift-comments
branch
from
f46fd06 to
11b1649
Compare
Contributor
|
(BTW force pushing makes it harder to review what has changed since this was last reviewed / approved) |
Member
Author
|
@alamb My excuses for the rebase. I had an odd conflict locally so I ended up 'rebasing' (in this and the other PR) |
Contributor
|
No worries-- I just thought I would mention it |
wgtmac
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix typos, grammar, and comment inconsistencies in the canonical Thrift schema definition.
Changes
is_compressedcommentcompressed_page_sizecomment in PageLocation (it includes the header; the field of the same name on PageHeader does not)Validation
Thrift definition compiles cleanly after all changes. No semantic/behavioral changes to the format specification.
Split from #572 for easier review.