Fix data race in SSLCertContext copy & assignment#13227
Open
AceMeistr wants to merge 1 commit into
Open
Conversation
Resolve concurrent read/write data races by using std::scoped_lock in operator= and locking other.ctx_mutex at the start of the copy constructor.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a concurrency bug in the TLS certificate context container (SSLCertContext) by ensuring its shared SSL_CTX state is consistently protected during copy construction and copy assignment, eliminating a concurrent read/write data race described in issue #13225.
Changes:
- Lock
other.ctx_mutexat the beginning ofSSLCertContextcopy construction to prevent concurrent mutation while copying. - Use
std::scoped_lockinSSLCertContext::operator=to acquire boththis->ctx_mutexandother.ctx_mutexin a deadlock-safe way before copying fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve concurrent read/write data races by using std::scoped_lock in operator= and locking other.ctx_mutex at the start of the copy constructor.
Replaced the manual lock definition and sequence with std::scoped_lock
Pushed lock guard to beginning to avoid source mutation during read to avoid data race by threads
ISSUE #13225