From 3b2db0a0806e26b0ed28d84c99a166129f0640b9 Mon Sep 17 00:00:00 2001 From: Ricky O'Steen Date: Wed, 15 Jul 2026 12:04:37 -0500 Subject: [PATCH 1/5] Add Python 3.14 to test matrix --- .github/workflows/ci_workflows.yml | 33 +++++++++++++++++------------- tox.ini | 2 +- 2 files changed, 20 insertions(+), 15 deletions(-) diff --git a/.github/workflows/ci_workflows.yml b/.github/workflows/ci_workflows.yml index 85a979d49..9c30c1a71 100644 --- a/.github/workflows/ci_workflows.yml +++ b/.github/workflows/ci_workflows.yml @@ -30,21 +30,26 @@ jobs: python: 3.x toxenv: codestyle - - name: Python 3.11 with remote data and coverage + - name: Python 3.14 with remote data and coverage os: ubuntu-latest - python: '3.11' - toxenv: py311-test-cov + python: '3.14' + toxenv: py313-test-cov toxargs: -v toxposargs: --remote-data=any - - name: Python 3.12 (Windows) + - name: Python 3.11 (MacOS) + os: ubuntu-latest + python: '3.11' + toxenv: py311-test + + - name: Python 3.13 (Windows) os: windows-latest - python: '3.12' - toxenv: py312-test + python: '3.13' + toxenv: py313-test - - name: Python 3.11 (MacOS) + - name: Python 3.12 (MacOS) os: macos-latest - python: '3.11' + python: '3.12' toxenv: py311-test - name: Python 3.13 (MacOS) @@ -111,17 +116,17 @@ jobs: fail-fast: false matrix: include: - - name: (Allowed Failure) Python 3.12 with remote data and dev version of key dependencies + - name: (Allowed Failure) Python 3.14 with remote data and dev version of key dependencies os: ubuntu-latest - python: '3.12' - toxenv: py312-test-devdeps + python: '3.14' + toxenv: py314-test-devdeps toxposargs: --remote-data=any # doctest failure due to different no. of significant digits on arm64 (#1146) - - name: Python 3.12 (macOS) + - name: Python 3.13 (macOS) os: macos-latest - python: '3.12' - toxenv: py312-test + python: '3.13' + toxenv: py313-test steps: - name: Checkout code diff --git a/tox.ini b/tox.ini index 4a2290e00..4e99fc33f 100644 --- a/tox.ini +++ b/tox.ini @@ -1,6 +1,6 @@ [tox] envlist = - py{311,312,313}-test{,-devdeps,-oldestdeps,-predeps}{,-cov,-external} + py{311,312,313,314}-test{,-devdeps,-oldestdeps,-predeps}{,-cov,-external} linkcheck codestyle isolated_build = true From f7357b18b0eb3e2230ce6891eceb66c97c5bb9f4 Mon Sep 17 00:00:00 2001 From: Ricky O'Steen Date: Wed, 15 Jul 2026 13:16:19 -0500 Subject: [PATCH 2/5] Add nitpick exception for QuantityInfoBase --- docs/nitpick-exceptions | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/nitpick-exceptions b/docs/nitpick-exceptions index 32591f3d7..6f3f28619 100644 --- a/docs/nitpick-exceptions +++ b/docs/nitpick-exceptions @@ -2,6 +2,7 @@ py:class astropy.nddata.mixins.ndio.NDIOMixin py:class astropy.nddata.mixins.ndslicing.NDSlicingMixin py:class astropy.nddata.mixins.ndarithmetic.NDArithmeticMixin +py:class astropy.units.QuantityInfoBase py:obj NDData py:obj NDUncertainty From a16c7ae43c54c8b8a576f05b3dda073574b6bfbf Mon Sep 17 00:00:00 2001 From: Ricky O'Steen Date: Thu, 16 Jul 2026 10:54:14 -0500 Subject: [PATCH 3/5] Fix missed 13->14 --- .github/workflows/ci_workflows.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci_workflows.yml b/.github/workflows/ci_workflows.yml index 9c30c1a71..c58fbf9cc 100644 --- a/.github/workflows/ci_workflows.yml +++ b/.github/workflows/ci_workflows.yml @@ -33,7 +33,7 @@ jobs: - name: Python 3.14 with remote data and coverage os: ubuntu-latest python: '3.14' - toxenv: py313-test-cov + toxenv: py314-test-cov toxargs: -v toxposargs: --remote-data=any From 14c43398a664df608958f1dfa2d31be8af43efaa Mon Sep 17 00:00:00 2001 From: Ricky O'Steen Date: Thu, 16 Jul 2026 11:22:14 -0500 Subject: [PATCH 4/5] Trying this again --- docs/nitpick-exceptions | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/nitpick-exceptions b/docs/nitpick-exceptions index 6f3f28619..f2bcc2203 100644 --- a/docs/nitpick-exceptions +++ b/docs/nitpick-exceptions @@ -2,7 +2,6 @@ py:class astropy.nddata.mixins.ndio.NDIOMixin py:class astropy.nddata.mixins.ndslicing.NDSlicingMixin py:class astropy.nddata.mixins.ndarithmetic.NDArithmeticMixin -py:class astropy.units.QuantityInfoBase py:obj NDData py:obj NDUncertainty @@ -10,6 +9,7 @@ py:obj NDUncertainty py:obj astropy.coordinates.SpectralQuantity py:class UnitBase py:class ConfigItem +py:class QuantityInfoBase # Classes in the SpectralCoord/SpectralQuantity methods for which we can't # control the API links. From c3ef537afe0291f26c348cdaa4893719b397c2f6 Mon Sep 17 00:00:00 2001 From: Ricky O'Steen Date: Fri, 17 Jul 2026 11:30:55 -0500 Subject: [PATCH 5/5] Remove redundant test (that's no longer failing), add non-remote 3.14 test --- .github/workflows/ci_workflows.yml | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci_workflows.yml b/.github/workflows/ci_workflows.yml index c58fbf9cc..720b8b446 100644 --- a/.github/workflows/ci_workflows.yml +++ b/.github/workflows/ci_workflows.yml @@ -37,7 +37,7 @@ jobs: toxargs: -v toxposargs: --remote-data=any - - name: Python 3.11 (MacOS) + - name: Python 3.11 (Linux) os: ubuntu-latest python: '3.11' toxenv: py311-test @@ -57,6 +57,11 @@ jobs: python: '3.13' toxenv: py313-test + - name: python 3.14 (Windows) + os: windows-latest + python: '3.14' + toxenv: py314-test + - name: Python 3.11 with oldest supported version of key dependencies os: ubuntu-latest python: '3.11' @@ -122,12 +127,6 @@ jobs: toxenv: py314-test-devdeps toxposargs: --remote-data=any - # doctest failure due to different no. of significant digits on arm64 (#1146) - - name: Python 3.13 (macOS) - os: macos-latest - python: '3.13' - toxenv: py313-test - steps: - name: Checkout code uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0