FIX: do not escape special characters on user and password#70
Open
scipioa wants to merge 1 commit into
Open
Conversation
Collaborator
|
Hello @scipioa , this is a long shot since you posted this pull-request a few years ago, but are you still interested in applying this change? If you do might I suggest to use strong quoting? |
Author
|
Hi @MichielMag , |
Collaborator
|
Hey Scipioa, thanks for responding! The reason I suggested strong quoting is because your fix only fixes one edge case. A problem like #81 would still happen. |
Owner
|
Open for a more agile solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User and password fields are already between quotes: add the escape character '' gives wrong password or username.