Fix/bec startup#825
Open
wakonig wants to merge 2 commits into
Open
Conversation
wakonig
force-pushed
the
fix/bec_startup
branch
2 times, most recently
from
edda1e6 to
dde5445
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make BEC startup more robust and align the user-facing high-level interface (HLI) experience across client variants by (1) preventing failures in plugin post-startup hooks from aborting startup and (2) moving HLI loading into the core client startup path.
Changes:
- Load
bec_hlifrombec_libclient startup (including Redis connection failure path) instead of in the IPython startup script. - Wrap execution of plugin
post_startup.pyin atry/exceptso a broken plugin post-startup does not prevent the client from starting.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
bec_lib/bec_lib/client.py |
Loads bec_hli during BECClient.start() (and on Redis connection failure). |
bec_ipython_client/bec_ipython_client/bec_startup.py |
Wraps plugin post_startup.py execution in try/except and removes redundant HLI loading from startup script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
two changes: