Skip to content

Post release fixes#995

Open
thunderbiscuit wants to merge 6 commits into
bitcoindevkit:masterfrom
thunderbiscuit:post-release
Open

Post release fixes#995
thunderbiscuit wants to merge 6 commits into
bitcoindevkit:masterfrom
thunderbiscuit:post-release

Conversation

@thunderbiscuit
Copy link
Copy Markdown
Member

@thunderbiscuit thunderbiscuit commented May 12, 2026 •
edited
Loading

I might bundle a few things in this one. Note that it should not be merged until we cut the official 3.0.0 release.

So far in this PR:

  1. I modified the local publishing of the bdk-android artifact to not require signatures
  2. I cherry-picked a fix of the changelog that cleans up our links
  3. I finalized the changelog for the 3.0 release
  4. I bumped the dev version of the library sitting on the master branch to 3.1.0-alpha.0

ItoroD
ItoroD approved these changes May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ItoroD ItoroD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4ac8e28

reez
reez reviewed May 20, 2026
View reviewed changes
Comment thread CHANGELOG.md Outdated
@thunderbiscuit thunderbiscuit mentioned this pull request May 26, 2026
Merged
@thunderbiscuit thunderbiscuit force-pushed the post-release branch 2 times, most recently from 624a77a to e5151e1 Compare June 3, 2026 17:51
@thunderbiscuit thunderbiscuit requested review from ItoroD and reez June 3, 2026 17:51
reez
reez reviewed Jun 3, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to merge/cherry-pick the final release/3.0 / v3.0.0 changes into this branch first, then apply the 3.1.0-alpha.0 bump?

@thunderbiscuit
Copy link
Copy Markdown
Member Author

thunderbiscuit commented Jun 4, 2026 •
edited
Loading

Did you have anything particular in mind? I'm looking at the commits on the release that are not on master and I think only one needs to be added, the bump to the androidSdk variable in 9a12b88. (oh and actually the bump of the lib version to 3.1.0-SNAPSHOT).

I think that's it, but let me know if I forgot anything!

@reez
Copy link
Copy Markdown
Collaborator

reez commented Jun 5, 2026

Did you have anything particular in mind? I'm looking at the commits on the release that are not on master and I think only one needs to be added, the bump to the androidSdk variable in 9a12b88. (oh and actually the bump of the lib version to 3.1.0-SNAPSHOT).

I think that's it, but let me know if I forgot anything!

Yep the android changes look good now. Other items I was thinking of would be:

  • Update the CHANGELOG.md v3.0.0 dependency list to match the tag: bdk_electrum 0.24.0, bdk_esplora 0.22.2, and bdk_kyoto 0.17.0.
  • Add the missing CHANGELOG.md v3.0.0 entry for Add optional timeout and retry parameters to the Electrum client constructor [#1010], plus the [#1010] link definition.
  • Update bdk-ffi/Cargo.toml from bdk_esplora = "0.22.1" to 0.22.2 (Cargo.lock already resolves bdk_esplora 0.22.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reez reez reez left review comments

@ItoroD ItoroD Awaiting requested review from ItoroD

Assignees

No one assigned

Labels

changelog: none

Projects

BDK-Bindings
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thunderbiscuit @reez @ItoroD