Ping returns ErrNoServers when no servers are configured#195
Open
c-tonneslan wants to merge 1 commit into
Open
Ping returns ErrNoServers when no servers are configured#195c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
A client built via New() without addresses (or after they're all removed via the ServerList) used to report Ping success because selector.Each iterated over an empty list and returned nil. That disagreed with every other client method, which surfaces ErrNoServers in the same situation, and let callers think they had a working client when nothing was reachable. Track whether any callback fired and return ErrNoServers when none did. Fixes bradfitz#179. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #179.
A client built via `New()` without addresses (or one whose `ServerList` was emptied later) reported `Ping()` success because `selector.Each` iterated over an empty list and returned nil. Other operations on the same client return `ErrNoServers` in that situation, so callers had no consistent way to tell whether the client could actually reach anything.
Track whether any per-server callback fired and surface `ErrNoServers` when none did. Real server errors keep propagating unchanged.
Added `TestPingNoServers` covering the zero-server case.