Fix receiver signature for corrected blinker signal.send() API in bw2data#41
Open
cmutel wants to merge 1 commit into
Open
Fix receiver signature for corrected blinker signal.send() API in bw2data#41cmutel wants to merge 1 commit into
cmutel wants to merge 1 commit into
Conversation
…ker API bw2data now passes the Projects instance as the blinker sender and the dataset as a dataset= keyword argument, per blinker's documented signal.send() API. Update receiver signature accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bw2datais fixing itssignal.send()calls to pass the sender as the first positional argument per blinker's documented API (see brightway-lca/brightway2-data#220).For
project_changed, the new call is:This means receivers are now called as
receiver(projects_instance, dataset=project_dataset)instead of the old brokenreceiver(project_dataset).Updated
update_allocation_strategies_on_project_changesignature from(project_dataset)to(sender, *, dataset, **kwargs).Test plan