Use DbStorage.toInClause and remove inClause - #6963
Merged
ray-roestenburg-da merged 1 commit intoSep 3, 2026
Merged
Conversation
Fixes canton-network#3900 Removes `inClause` in favor of `DbStorage.toInClause`. Signed-off-by: Matt Dziuban <mrdziuban@gmail.com>
mrdziuban
force-pushed
the
mrdziuban/toInClause/3900
branch
from
September 2, 2026 13:37
919b754 to
d12fc61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3900
Best viewed with whitespace changes ignored: https://github.com/canton-network/splice/pull/6963/changes?w=1
I checked every spot
toInClauseis now used to verify that the lack of a leading space I mentioned is not a problem -- all of the queries already added a space before appending the result of the call toinClause.Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines