Skip to content

CS-11328: robust primary BoxelButton focus ring; darken with the fill #5116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukemelia merged 1 commit into from
Jun 5, 2026
Merged

CS-11328: robust primary BoxelButton focus ring; darken with the fill #5116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions packages/boxel-ui/addon/src/components/selection-menu/index.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,14 +102,19 @@ export default class SelectionMenu extends Component<Signature> {
--boxel-button-padding: var(--boxel-sp-5xs) var(--boxel-sp-xs);
--boxel-button-min-width: 0;
}
/* Keyboard focus ring just outside the button. (Set explicitly so it
renders regardless of the global button outline setup.) */
/* Keyboard focus ring: a lighter tint of the current fill, so it stays
visible against the highlight button (a highlight-colored ring would
blend into it) while tracking the fill as it darkens. Sits snug
against the button (1px) rather than floating off it. Defined here
rather than on BoxelButton because boxel-ui's unlayered global
`button:focus` rule overrides the button's own layered focus styles. */
.selection-menu-trigger:focus-visible {
outline: var(--boxel-outline-width) var(--boxel-outline-style)
var(--boxel-highlight);
outline-offset: 2px;
color-mix(in oklab, var(--boxel-button-color) 70%, white);
outline-offset: 1px;
}
/* Deepen the fill while the menu is open, matching Button's hover. */
/* Deepen the fill while the menu is open, matching Button's hover; the
focus ring's color-mix tracks the fill, so it darkens to match. */
.selection-menu-trigger[aria-expanded='true'] {
--boxel-button-color: var(--boxel-highlight-hover);
}
Expand Down
Loading