Incomplete Test Case in test_tasks.py

[drona-gyawali]

I noticed that the below test case in test_tasks.py was written by someone and commented out, possibly because there was an issue that wasn’t fully resolved. I’ve gone through the code and made some progress on it. With your permission, I’m willing to take ownership of this and complete the test case. I can also raise an issue for it if needed.

Additionally, I apologize for not discussing the previous PR with you beforehand. I’ll make sure to consult with you next time before submitting.

Looking forward to your feedback!

 # TO DO
    # @patch("impossible_travel.tasks.check_fields")
    # @patch.object(tasks.Search, "execute")
    # def test_process_user(self, mock_execute, mock_check_fields):
    #     data_elastic_sorted_dot_not = []
    #     imp_travel = impossible_travel.Impossible_Travel()
    #     data_elastic = load_test_data("test_data_process_user")
    #     data_elastic_sorted = sorted(data_elastic, key=lambda d: d["@timestamp"])
    #     for data in data_elastic_sorted:
    #         data_elastic_sorted_dot_not.append(DictStruct(kwargs=data))
    #     data_results = load_test_data("test_data_process_user_result")
    #     mock_execute.return_value = data_elastic_sorted_dot_not
    #     start_date = timezone.datetime(2023, 3, 8, 0, 0, 0)
    #     end_date = timezone.datetime(2023, 3, 8, 23, 59, 59)
    #     iso_start_date = imp_travel.validate_timestamp(start_date)
    #     iso_end_date = imp_travel.validate_timestamp(end_date)
    #     db_user = User.objects.get(username="Lorena Goldoni")
    #     tasks.process_user(db_user, iso_start_date, iso_end_date)
    #     mock_check_fields.assert_called_once_with(db_user, data_results)

[Lorygold]

Hi @drona-gyawali, thank you for your interest, but I'm working on a big refactor about the ingestion process,so the tests will also undergo changes

[drona-gyawali]

Thanks for the update and If there's anything I can assist with in the refactor process, I'd be happy to help!