From 4a9ff8e0cf2727c87b8b5d93d4e3ee6082410898 Mon Sep 17 00:00:00 2001 From: Hannah Date: Fri, 6 Feb 2026 19:58:20 +0100 Subject: [PATCH 1/6] Enable RPD reconstruction by default. --- .../HcalRecProducers/plugins/ZdcHitReconstructor_Run3.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/RecoLocalCalo/HcalRecProducers/plugins/ZdcHitReconstructor_Run3.cc b/RecoLocalCalo/HcalRecProducers/plugins/ZdcHitReconstructor_Run3.cc index 649cec23d2dcd..1b6d633abe28b 100644 --- a/RecoLocalCalo/HcalRecProducers/plugins/ZdcHitReconstructor_Run3.cc +++ b/RecoLocalCalo/HcalRecProducers/plugins/ZdcHitReconstructor_Run3.cc @@ -177,7 +177,7 @@ void ZdcHitReconstructor_Run3::fillDescriptions(edm::ConfigurationDescriptions& desc.add("digiLabelQIE10ZDC", edm::InputTag("hcalDigis", "ZDC")); desc.add("Subdetector", "ZDC"); desc.add("dropZSmarkedPassed", true); - desc.add("skipRPD", true); + desc.add("skipRPD", false); desc.add("recoMethod", 1); desc.add("correctionMethodEM", 1); desc.add("correctionMethodHAD", 1); @@ -237,4 +237,4 @@ void ZdcHitReconstructor_Run3::fillDescriptions(edm::ConfigurationDescriptions& } //define this as a plug-in -DEFINE_FWK_MODULE(ZdcHitReconstructor_Run3); \ No newline at end of file +DEFINE_FWK_MODULE(ZdcHitReconstructor_Run3); From c5828cb285d3e46a1e722aaaf5652194a8b516b2 Mon Sep 17 00:00:00 2001 From: Hannah Date: Sun, 8 Feb 2026 01:59:46 +0100 Subject: [PATCH 2/6] Change implementation to process modifier. --- Configuration/Eras/python/Era_Run3_2026_UPC_cff.py | 3 ++- Configuration/Eras/python/Era_Run3_pp_on_PbPb_2025_cff.py | 1 + Configuration/Eras/python/Era_Run3_pp_on_PbPb_2026_cff.py | 1 + Configuration/ProcessModifiers/python/rpdReco_cff.py | 3 +++ .../HcalRecProducers/plugins/ZdcHitReconstructor_Run3.cc | 2 +- 5 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 Configuration/ProcessModifiers/python/rpdReco_cff.py diff --git a/Configuration/Eras/python/Era_Run3_2026_UPC_cff.py b/Configuration/Eras/python/Era_Run3_2026_UPC_cff.py index 433b6fafe74f0..1ccc56078bbf8 100644 --- a/Configuration/Eras/python/Era_Run3_2026_UPC_cff.py +++ b/Configuration/Eras/python/Era_Run3_2026_UPC_cff.py @@ -2,9 +2,10 @@ from Configuration.Eras.Era_Run3_2026_cff import Run3_2026 from Configuration.ProcessModifiers.egamma_lowPt_exclusive_cff import egamma_lowPt_exclusive +from Configuration.ProcessModifiers.rpdReco_cff import rpdReco from Configuration.Eras.Modifier_highBetaStar_cff import highBetaStar from Configuration.Eras.Modifier_dedx_lfit_cff import dedx_lfit from Configuration.Eras.Modifier_run3_upc_cff import run3_upc from Configuration.Eras.Modifier_run3_upc_2026_cff import run3_upc_2026 -Run3_2026_UPC = cms.ModifierChain(Run3_2026, egamma_lowPt_exclusive, highBetaStar, dedx_lfit, run3_upc, run3_upc_2026) +Run3_2026_UPC = cms.ModifierChain(Run3_2026, egamma_lowPt_exclusive, rpdReco, highBetaStar, dedx_lfit, run3_upc, run3_upc_2026) diff --git a/Configuration/Eras/python/Era_Run3_pp_on_PbPb_2025_cff.py b/Configuration/Eras/python/Era_Run3_pp_on_PbPb_2025_cff.py index b10f94b27da63..4804836cf6a38 100644 --- a/Configuration/Eras/python/Era_Run3_pp_on_PbPb_2025_cff.py +++ b/Configuration/Eras/python/Era_Run3_pp_on_PbPb_2025_cff.py @@ -2,6 +2,7 @@ from Configuration.Eras.Era_Run3_2025_cff import Run3_2025 from Configuration.ProcessModifiers.pp_on_AA_cff import pp_on_AA +from Configuration.ProcessModifiers.rpdReco_cff import rpdReco from Configuration.Eras.Modifier_pp_on_PbPb_run3_cff import pp_on_PbPb_run3 from Configuration.Eras.Modifier_pp_on_PbPb_run3_2025_cff import pp_on_PbPb_run3_2025 from Configuration.Eras.Modifier_dedx_lfit_cff import dedx_lfit diff --git a/Configuration/Eras/python/Era_Run3_pp_on_PbPb_2026_cff.py b/Configuration/Eras/python/Era_Run3_pp_on_PbPb_2026_cff.py index fc0996ce9bf5f..a89204066bc2e 100644 --- a/Configuration/Eras/python/Era_Run3_pp_on_PbPb_2026_cff.py +++ b/Configuration/Eras/python/Era_Run3_pp_on_PbPb_2026_cff.py @@ -2,6 +2,7 @@ from Configuration.Eras.Era_Run3_2026_cff import Run3_2026 from Configuration.ProcessModifiers.pp_on_AA_cff import pp_on_AA +from Configuration.ProcessModifiers.rpdReco_cff import rpdReco from Configuration.Eras.Modifier_pp_on_PbPb_run3_cff import pp_on_PbPb_run3 from Configuration.Eras.Modifier_pp_on_PbPb_run3_2026_cff import pp_on_PbPb_run3_2026 from Configuration.Eras.Modifier_dedx_lfit_cff import dedx_lfit diff --git a/Configuration/ProcessModifiers/python/rpdReco_cff.py b/Configuration/ProcessModifiers/python/rpdReco_cff.py new file mode 100644 index 0000000000000..924130a583530 --- /dev/null +++ b/Configuration/ProcessModifiers/python/rpdReco_cff.py @@ -0,0 +1,3 @@ +import FWCore.ParameterSet.Config as cms + +rpdReco = cms.Modifier() diff --git a/RecoLocalCalo/HcalRecProducers/plugins/ZdcHitReconstructor_Run3.cc b/RecoLocalCalo/HcalRecProducers/plugins/ZdcHitReconstructor_Run3.cc index 1b6d633abe28b..dd5675eb195d5 100644 --- a/RecoLocalCalo/HcalRecProducers/plugins/ZdcHitReconstructor_Run3.cc +++ b/RecoLocalCalo/HcalRecProducers/plugins/ZdcHitReconstructor_Run3.cc @@ -177,7 +177,7 @@ void ZdcHitReconstructor_Run3::fillDescriptions(edm::ConfigurationDescriptions& desc.add("digiLabelQIE10ZDC", edm::InputTag("hcalDigis", "ZDC")); desc.add("Subdetector", "ZDC"); desc.add("dropZSmarkedPassed", true); - desc.add("skipRPD", false); + desc.add("skipRPD", true); desc.add("recoMethod", 1); desc.add("correctionMethodEM", 1); desc.add("correctionMethodHAD", 1); From caee768310a9dba2ae5a080f5e3a451ad814ca4c Mon Sep 17 00:00:00 2001 From: Hannah Date: Mon, 9 Feb 2026 23:41:57 +0100 Subject: [PATCH 3/6] Add file for which the process modifier is used. --- .../HcalRecProducers/plugins/ZdcHitReconstructor_Run3.cc | 2 +- RecoLocalCalo/HcalRecProducers/python/zdcrecoRun3_cfi.py | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 RecoLocalCalo/HcalRecProducers/python/zdcrecoRun3_cfi.py diff --git a/RecoLocalCalo/HcalRecProducers/plugins/ZdcHitReconstructor_Run3.cc b/RecoLocalCalo/HcalRecProducers/plugins/ZdcHitReconstructor_Run3.cc index dd5675eb195d5..017e0ff7f1684 100644 --- a/RecoLocalCalo/HcalRecProducers/plugins/ZdcHitReconstructor_Run3.cc +++ b/RecoLocalCalo/HcalRecProducers/plugins/ZdcHitReconstructor_Run3.cc @@ -231,7 +231,7 @@ void ZdcHitReconstructor_Run3::fillDescriptions(edm::ConfigurationDescriptions& psd0.add("maxADCvalue", 255); desc.add("saturationParameters", psd0); } - descriptions.add("zdcrecoRun3", desc); + descriptions.add("zdcRecoRun3", desc); // or use the following to generate the label from the module's C++ type //descriptions.addWithDefaultLabel(desc); } diff --git a/RecoLocalCalo/HcalRecProducers/python/zdcrecoRun3_cfi.py b/RecoLocalCalo/HcalRecProducers/python/zdcrecoRun3_cfi.py new file mode 100644 index 0000000000000..2681045131e8a --- /dev/null +++ b/RecoLocalCalo/HcalRecProducers/python/zdcrecoRun3_cfi.py @@ -0,0 +1,7 @@ +import FWCore.ParameterSet.Config as cms +import RecoLocalCalo.HcalRecProducers.zdcRecoRun3_cfi +# clone (new) zdcrecoRun3 from imtermediate zdcRecoRun3 +zdcrecoRun3 = RecoLocalCalo.HcalRecProducers.zdcRecoRun3_cfi.zdcRecoRun3.clone() +# apply modifier(s) +from Configuration.ProcessModifiers.rpdReco_cff import rpdReco +rpdReco.toModify(zdcrecoRun3, skipRPD = False) From fa81aaaaa45e9933584050da8263561bdbea24cb Mon Sep 17 00:00:00 2001 From: Hannah Date: Mon, 9 Feb 2026 23:53:04 +0100 Subject: [PATCH 4/6] Add rpd reco back in. --- Configuration/Eras/python/Era_Run3_pp_on_PbPb_2025_cff.py | 2 +- Configuration/Eras/python/Era_Run3_pp_on_PbPb_2026_cff.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Configuration/Eras/python/Era_Run3_pp_on_PbPb_2025_cff.py b/Configuration/Eras/python/Era_Run3_pp_on_PbPb_2025_cff.py index 4804836cf6a38..c665985d474a2 100644 --- a/Configuration/Eras/python/Era_Run3_pp_on_PbPb_2025_cff.py +++ b/Configuration/Eras/python/Era_Run3_pp_on_PbPb_2025_cff.py @@ -7,4 +7,4 @@ from Configuration.Eras.Modifier_pp_on_PbPb_run3_2025_cff import pp_on_PbPb_run3_2025 from Configuration.Eras.Modifier_dedx_lfit_cff import dedx_lfit -Run3_pp_on_PbPb_2025 = cms.ModifierChain(Run3_2025, dedx_lfit, pp_on_AA, pp_on_PbPb_run3, pp_on_PbPb_run3_2025) +Run3_pp_on_PbPb_2025 = cms.ModifierChain(Run3_2025, dedx_lfit, pp_on_AA, rpdReco, pp_on_PbPb_run3, pp_on_PbPb_run3_2025) diff --git a/Configuration/Eras/python/Era_Run3_pp_on_PbPb_2026_cff.py b/Configuration/Eras/python/Era_Run3_pp_on_PbPb_2026_cff.py index a89204066bc2e..111bdfc39603e 100644 --- a/Configuration/Eras/python/Era_Run3_pp_on_PbPb_2026_cff.py +++ b/Configuration/Eras/python/Era_Run3_pp_on_PbPb_2026_cff.py @@ -7,4 +7,4 @@ from Configuration.Eras.Modifier_pp_on_PbPb_run3_2026_cff import pp_on_PbPb_run3_2026 from Configuration.Eras.Modifier_dedx_lfit_cff import dedx_lfit -Run3_pp_on_PbPb_2026 = cms.ModifierChain(Run3_2026, dedx_lfit, pp_on_AA, pp_on_PbPb_run3, pp_on_PbPb_run3_2026) +Run3_pp_on_PbPb_2026 = cms.ModifierChain(Run3_2026, dedx_lfit, pp_on_AA, rpdReco, pp_on_PbPb_run3, pp_on_PbPb_run3_2026) From a6f0877617a1d84f8dbdc5511f381274cec87942 Mon Sep 17 00:00:00 2001 From: Hannah Date: Wed, 15 Apr 2026 22:08:17 +0200 Subject: [PATCH 5/6] Add RPD reco to 2025 as well --- Configuration/Eras/python/Era_Run3_2025_UPC_cff.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Configuration/Eras/python/Era_Run3_2025_UPC_cff.py b/Configuration/Eras/python/Era_Run3_2025_UPC_cff.py index 5cb0a600c08c2..9ea192e363842 100644 --- a/Configuration/Eras/python/Era_Run3_2025_UPC_cff.py +++ b/Configuration/Eras/python/Era_Run3_2025_UPC_cff.py @@ -2,9 +2,10 @@ from Configuration.Eras.Era_Run3_2025_cff import Run3_2025 from Configuration.ProcessModifiers.egamma_lowPt_exclusive_cff import egamma_lowPt_exclusive +from Configuration.ProcessModifiers.rpdReco_cff import rpdReco from Configuration.Eras.Modifier_highBetaStar_cff import highBetaStar from Configuration.Eras.Modifier_dedx_lfit_cff import dedx_lfit from Configuration.Eras.Modifier_run3_upc_cff import run3_upc from Configuration.Eras.Modifier_run3_upc_2025_cff import run3_upc_2025 -Run3_2025_UPC = cms.ModifierChain(Run3_2025, egamma_lowPt_exclusive, highBetaStar, dedx_lfit, run3_upc, run3_upc_2025) +Run3_2025_UPC = cms.ModifierChain(Run3_2025, egamma_lowPt_exclusive, rpdReco, highBetaStar, dedx_lfit, run3_upc, run3_upc_2025) From 8a3aa02aec510edc49b75bac043e02014239ad86 Mon Sep 17 00:00:00 2001 From: Hannah Date: Thu, 16 Apr 2026 19:36:04 +0200 Subject: [PATCH 6/6] Workaround for missing conditions in summer 2025. --- Configuration/Eras/python/Era_Run3_2025_UPC_OXY_cff.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Configuration/Eras/python/Era_Run3_2025_UPC_OXY_cff.py b/Configuration/Eras/python/Era_Run3_2025_UPC_OXY_cff.py index cd0f47cb9cbab..e17523b6fed1e 100644 --- a/Configuration/Eras/python/Era_Run3_2025_UPC_OXY_cff.py +++ b/Configuration/Eras/python/Era_Run3_2025_UPC_OXY_cff.py @@ -2,5 +2,6 @@ from Configuration.Eras.Era_Run3_2025_UPC_cff import Run3_2025_UPC from Configuration.Eras.Modifier_run3_oxygen_cff import run3_oxygen +from Configuration.ProcessModifiers.rpdReco_cff import rpdReco -Run3_2025_UPC_OXY = cms.ModifierChain(Run3_2025_UPC, run3_oxygen) +Run3_2025_UPC_OXY = cms.ModifierChain(Run3_2025_UPC.copyAndExclude([rpdReco]), run3_oxygen)