From 9efb79006a02129b22e4928291d27eaedf19c663 Mon Sep 17 00:00:00 2001 From: Tom Hunze Date: Sat, 29 Nov 2025 22:52:11 +0100 Subject: [PATCH] tests: fix for lxml 6 lxml 6 doesn't find a `` tag via the XPath expression `//body` anymore when the parsed HTML doesn't contain any tags at all. This caused some of splinter's tests to fail when lxml 6 is used. See https://hydra.nixos.org/build/314264704/nixlog/1 for logs of the test failures. --- tests/fake_django/urls.py | 5 +++-- tests/fake_webapp.py | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/fake_django/urls.py b/tests/fake_django/urls.py index 2ab75ff65..bd736abe5 100644 --- a/tests/fake_django/urls.py +++ b/tests/fake_django/urls.py @@ -52,7 +52,8 @@ def post_form(request): def request_headers(request): - body = "\n".join(f"{key}: {value}" for key, value in request.META.items()) + headers = "\n".join(f"{key}: {value}" for key, value in request.META.items()) + body = f"{headers}" return HttpResponse(body) @@ -67,7 +68,7 @@ def upload_file(request): def foo(request): - return HttpResponse("BAR!") + return HttpResponse("BAR!") def query_string(request): diff --git a/tests/fake_webapp.py b/tests/fake_webapp.py index ccd5bab60..efc31c5f1 100644 --- a/tests/fake_webapp.py +++ b/tests/fake_webapp.py @@ -119,12 +119,12 @@ def upload_file(): @app.route("/headers", methods=["GET"]) def request_headers(): - return str(request.headers) + return f"{request.headers}" @app.route("/foo") def foo(): - return "BAR!" + return "BAR!" @app.route("/query", methods=["GET"])