Skip to content

Overlapping ESLint rules for unnecessary Promise wrap #29

Description

@Tlacenka

User story

As an engineer, I want only one ESLint rule to target a given issue, so that I only get one finding per issue and avoid unnecessary noise.

Acceptance criteria

There is only one rule for reporting unnecessary Promise wrappers.

Minimal reproduction of current behaviour

The promise/no-return-wrap rule included from recommended config here .
The unicorn/no-useless-promise-resolve-reject rule included in recommended config here seems to be an expanded and auto-fixable version of that rule - it includes finally and yield constructs.

Desired behaviour showcase

The promise/no-return-wrap can be removed.

Which configuration is this related to?

default

ESLint version

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions