From 0b3055f12a8fd490501c197536892bc8ca9f29be Mon Sep 17 00:00:00 2001 From: Conrad Taylor Date: Sat, 25 Apr 2026 17:10:34 -0700 Subject: [PATCH 1/2] Code cleanup. --- .github/workflows/call-docker-build.yaml | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/.github/workflows/call-docker-build.yaml b/.github/workflows/call-docker-build.yaml index 1bf7284..9023bf4 100644 --- a/.github/workflows/call-docker-build.yaml +++ b/.github/workflows/call-docker-build.yaml @@ -8,13 +8,13 @@ on: - main # don't rebuild image if someone only edited unrelated files paths-ignore: - - 'README.md' - - '.github/linters/**' + - "README.md" + - ".github/linters/**" pull_request: # don't rebuild image if someone only edited unrelated files paths-ignore: - - 'README.md' - - '.github/linters/**' + - "README.md" + - ".github/linters/**" # cancel any previously-started, yet still active runs of this workflow on the same branch concurrency: @@ -40,15 +40,14 @@ jobs: contents: read packages: write # needed to push docker image to ghcr.io pull-requests: write # needed to create and update comments in PRs + # secrets: - # secrets: + # Only needed if with:dockerhub-enable is true below + # https://hub.docker.com/settings/security + # dockerhub-username: ${{ secrets.DOCKERHUB_USERNAME }} + # dockerhub-token: ${{ secrets.DOCKERHUB_TOKEN }} - # Only needed if with:dockerhub-enable is true below - # https://hub.docker.com/settings/security - # dockerhub-username: ${{ secrets.DOCKERHUB_USERNAME }} - # dockerhub-token: ${{ secrets.DOCKERHUB_TOKEN }} - - with: + # with: # NOTE: there are lots of input options for this reusable workflow # read the comments in the inputs area of the reusable workflow for more info # https://github.com/BretFisher/docker-build-workflow/blob/main/.github/workflows/reusable-docker-build.yaml @@ -74,6 +73,6 @@ jobs: # platforms are *native GitHub Runners by default, so only amd64 and/or arm64 are supported, and must be in JSON syntax. # for more platform build options, there's a "QEMU" reusable workflow option in this repo's .github/workflows folder - platforms: '["linux/amd64", "linux/arm64"]' + # platforms: '["linux/amd64", "linux/arm64"]' # comment-enable: true From bc98c01c9c95631cea2f7729948aaf81dc8ff089 Mon Sep 17 00:00:00 2001 From: Conrad Taylor Date: Sat, 25 Apr 2026 17:34:10 -0700 Subject: [PATCH 2/2] Code cleanup. --- .github/workflows/call-docker-build.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/call-docker-build.yaml b/.github/workflows/call-docker-build.yaml index 9023bf4..9eda05e 100644 --- a/.github/workflows/call-docker-build.yaml +++ b/.github/workflows/call-docker-build.yaml @@ -47,7 +47,7 @@ jobs: # dockerhub-username: ${{ secrets.DOCKERHUB_USERNAME }} # dockerhub-token: ${{ secrets.DOCKERHUB_TOKEN }} - # with: + # with: # NOTE: there are lots of input options for this reusable workflow # read the comments in the inputs area of the reusable workflow for more info # https://github.com/BretFisher/docker-build-workflow/blob/main/.github/workflows/reusable-docker-build.yaml