[codex] clarify issue and pr defaults and language rules#1
Conversation
|
🤖 Hi @crazygit, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
This PR successfully clarifies the language requirements and default behaviors for Issues, Pull Requests, and Commits. It establishes a clear convention of using Chinese for user-facing content (Issues/PRs) while maintaining English for developer-facing commit messages, and adds automated tests to enforce these constraints.
🔍 General Feedback
- Consistency: The alignment between
issue-createandissue-prlabels is a great improvement. - Automation: Adding skill-loading tests for documentation content is a proactive way to prevent regressions in AI instructions.
- Clarity: The explicit mention of
--assignee "@me"and Chinese language rules removes ambiguity for the AI agent.
There was a problem hiding this comment.
Code Review
This pull request updates the documentation and command logic for the issue-commit, issue-create, and issue-pr skills to standardize language and metadata. Key changes include enforcing Chinese for Issue and PR titles and bodies while explicitly keeping commit messages in English. Additionally, the PR introduces automatic assignment to the current user via --assignee "@me" and implements default label inheritance and mapping for both Issues and PRs. New tests have been added to verify these content constraints across the modified skills. I have no feedback to provide as no review comments were submitted.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation and workflow instructions for issue creation, pull requests, and commits. Key changes include enforcing Chinese for issue and PR titles and bodies while keeping commit messages in English, and adding requirements for default labels and automatic assignment to the current user. Review feedback points out a syntax error in the newly added test script and formatting artifacts (stray '+' signs) in the documentation that need to be corrected.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Summary
issue-createandissue-prwith the intended defaults for labels and self-assignmentWhy
The current skill docs were inconsistent about default label/assignee behavior and PR language requirements. This change makes the expected defaults explicit and prevents regressions.
Validation
bash tests/skill-loading/run-tests.shbash tests/state-machine/run-tests.sh