fix(qt): clear owned filter without wallet

Author: PastaPastaPasta

src/qt/masternodelist.cpp

@@ -21,6 +21,7 @@
 #include <QHeaderView>
 #include <QMetaObject>
 #include <QSettings>
+#include <QSignalBlocker>
 #include <QThread>
 
 #include <set>
@@ -189,6 +190,13 @@ void MasternodeList::setWalletModel(WalletModel* model)
     if (walletModel) {
         QSettings settings;
         ui->checkBoxOwned->setChecked(settings.value("mnListOwnedOnly", false).toBool());
+    } else {
+        const QSignalBlocker blocker{ui->checkBoxOwned};
+        ui->checkBoxOwned->setChecked(false);
+        m_proxy_model->setShowOwnedOnly(false);
+        m_proxy_model->setMyMasternodeHashes({});
+        m_proxy_model->forceInvalidateFilter();
+        updateFilteredCount();
     }
 }
 

src/qt/test/masternodewidgettests.cpp

@@ -29,6 +29,7 @@
 
 #include <QAbstractButton>
 #include <QApplication>
+#include <QCheckBox>
 #include <QComboBox>
 #include <QDoubleSpinBox>
 #include <QLabel>
@@ -666,8 +667,10 @@ void MasternodeWidgetTests::masternodeListRegistrationAvailability()
 
     MasternodeList list;
     auto* const register_button{list.findChild<QPushButton*>("btnRegisterMasternode")};
+    auto* const owned_checkbox{list.findChild<QCheckBox*>("checkBoxOwned")};
     auto* const context_menu{list.findChild<QMenu*>(QString{}, Qt::FindDirectChildrenOnly)};
     QVERIFY(register_button != nullptr);
+    QVERIFY(owned_checkbox != nullptr);
     QVERIFY(context_menu != nullptr);
     QVERIFY(context_menu->toolTipsVisible());
     QVERIFY(!register_button->isEnabled());
@@ -680,6 +683,20 @@ void MasternodeWidgetTests::masternodeListRegistrationAvailability()
     list.setClientModel(&client_model);
     QVERIFY(register_button->isEnabled());
 
+    owned_checkbox->setChecked(true);
+    list.setWalletModel(nullptr);
+    QVERIFY(!register_button->isEnabled());
+    QVERIFY(register_button->toolTip().contains("requires a wallet", Qt::CaseInsensitive));
+    QVERIFY(!owned_checkbox->isEnabled());
+    QVERIFY(!owned_checkbox->isChecked());
+
+    // Attaching the wallet again restores the user's saved owned-only choice.
+    list.setWalletModel(&wallet_model);
+    QVERIFY(register_button->isEnabled());
+    QVERIFY(owned_checkbox->isEnabled());
+    QVERIFY(owned_checkbox->isChecked());
+    owned_checkbox->setChecked(false);
+
     list.setClientModel(nullptr);
     QVERIFY(!register_button->isEnabled());
     QVERIFY(register_button->toolTip().contains("node is ready", Qt::CaseInsensitive));