java.lang.StackOverflowError with deep recursive function call, should be `RUNTIME ERROR: max stack frames exceeded.`

[He-Pin]

recursive_function utest may fail if the stack is not rich.

local infiniteLoop(x) = infiniteLoop(x + 1);
infiniteLoop(0)

A better way may be to evaluate with an ArrayDequeue, but this will need some rework on the evaluator.

hepin@Mac ~ % ./sjsonnet rec_function.jsonnet 
Exception in thread "main" java.lang.StackOverflowError
	at scala.scalanative.runtime.package$.throwPendingStackOverflowError(Unknown Source)
	at scala.scalanative.runtime.package$.throwPendingStackOverflowError(Unknown Source)
	at <none>.scalanative_StackOverflowGuards_close(Unknown Source)
	at sjsonnet.Evaluator.visitExpr(Unknown Source)
	at sjsonnet.Evaluator.visitExpr(Unknown Source)
	at sjsonnet.Evaluator.visitExpr(Unknown Source)
	at sjsonnet.Evaluator.visitExpr(Unknown Source)
	at sjsonnet.Evaluator.visitExpr(Unknown Source)
	at sjsonnet.Evaluator.visitExpr(Unknown Source)
	at sjsonnet.Evaluator.visitExpr(Unknown Source)
	at sjsonnet.Evaluator.visitExpr(Unknown Source)
	at sjsonnet.Evaluator.visitExpr(Unknown Source)
	at sjsonnet.Evaluator.visitExpr(Unknown Source)
	at sjsonnet.Evaluator.visitExpr(Unknown Source)
	at sjsonnet.Evaluator.visitExpr(Unknown Source)
	at sjsonnet.Evaluator.visitExpr(Unknown Source)
	at sjsonnet.Evaluator.visitExpr(Unknown Source)
	at sjsonnet.Evaluator.visitExpr(Unknown Source)
	at sjsonnet.Evaluator.visitExpr(Unknown Source)
	at sjsonnet.Evaluator.visitExpr(Unknown Source)
	at sjsonnet.Evaluator.visitExpr(Unknown Source)
	at sjsonnet.Evaluator.visitExpr(Unknown Source)
	at sjsonnet.Evaluator.visitExpr(Unknown Source)

[He-Pin]

I checked both go-jsonnet and cpp jsonnet, I found both are using a ArrayDeque like thing to do a stack , which may is more complex, may not need that for now?

and in CertainLach/jrsonnet#121 , @CertainLach is using a hypered one.

Or, we can make use of scala.util.control.TailCalls to handle it.

[He-Pin]

Error: RUNTIME ERROR: max stack frames exceeded.
	example1.jsonnet:1:25-44	function <infiniteLoop>
	example1.jsonnet:1:25-44	function <infiniteLoop>
	example1.jsonnet:1:25-44	function <infiniteLoop>
	example1.jsonnet:1:25-44	function <infiniteLoop>
	example1.jsonnet:1:25-44	function <infiniteLoop>
	example1.jsonnet:1:25-44	function <infiniteLoop>
	example1.jsonnet:1:25-44	function <infiniteLoop>
	example1.jsonnet:1:25-44	function <infiniteLoop>
	example1.jsonnet:1:25-44	function <infiniteLoop>
	example1.jsonnet:1:25-44	function <infiniteLoop>
	...
	example1.jsonnet:1:25-44	function <infiniteLoop>
	example1.jsonnet:1:25-44	function <infiniteLoop>
	example1.jsonnet:1:25-44	function <infiniteLoop>
	example1.jsonnet:1:25-44	function <infiniteLoop>
	example1.jsonnet:1:25-44	function <infiniteLoop>
	example1.jsonnet:1:25-44	function <infiniteLoop>
	example1.jsonnet:1:25-44	function <infiniteLoop>
	example1.jsonnet:1:25-44	function <infiniteLoop>
	example1.jsonnet:2:1-16	$
	During evaluation	

I think this error message is better than the current java.lang.StackOverflowError