Fix issue where documents in a documentset couldn't be renamed.

src/lua/documentset.lua

@@ -187,13 +187,13 @@ DocumentSet.setCurrent = function(self, name)
 end
 
 DocumentSet.renameDocument = function(self, oldname, newname)
-	if self.documents[newname] then
+	if self:findDocument(newname) then
 		return false
 	end
 
-	local d = self.documents[oldname]
-	self.documents[oldname] = nil
-	self.documents[newname] = d
+	local d = self:findDocument(oldname)
+	self._documentIndex[oldname] = nil
+	self._documentIndex[newname] = d
 	d.name = newname
 
 	self:touch()

tests/build.py

@@ -58,6 +58,7 @@
     "weirdness-combining-words",
     "weirdness-delete-word",
     "weirdness-deletion-with-multiple-spaces",
+    "weirdness-document-rename",
     "weirdness-documentset-default-name",
     "weirdness-end-of-lines",
     "weirdness-forward-delete",

tests/weirdness-document-rename.lua

@@ -0,0 +1,8 @@
+--!nonstrict
+loadfile("tests/testsuite.lua")()
+
+AssertEquals(currentDocument.name, "main")
+documentSet:renameDocument("main", "new")
+
+AssertEquals(currentDocument.name, "new")
+AssertTableEquals({["new"]= currentDocument}, documentSet._documentIndex)