Consistent preconditions for SPV/RPC sync.#2634
Merged
Merged
Conversation
In order to start a wallet sync over either RPC or SPV, the wallet must already be loaded and must not already have an associated syncer. RpcSync was missing the check for a loaded wallet (which could lead to a panic). SpvSync was missing the check for an already existing syncer.
davecgh
approved these changes
Apr 29, 2026
Member
davecgh
left a comment
davecgh
left a comment
There was a problem hiding this comment.
No objections to being more defensive about preconditions as that's a good thing in general.
While I'm not super familiar with the code here since it's not my area, I don't think there is any real issue at the moment because hitting this would require the code that sets everything up to be doing the wrong thing and it evidently is not given it would be crashing if it were.
Member
Author
|
It's a bit of a contrived situation, but its possible to hit the panic by starting dcrwallet with |
jrick
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to start a wallet sync over either RPC or SPV, the wallet must already be loaded and must not already have an associated syncer.
RpcSync was missing the check for a loaded wallet (which could lead to a panic).
SpvSync was missing the check for an already existing syncer.